Optional set of valid platforms and architectures
Metadata
Current evaluation
Optional platform and architecture validation was merged in PR #130 (commit 6741479) and released in 2.3.0.
Resolution: closed resolved
Reason: PR #130 added optional valid_platforms and valid_architectures validation to GrammarProcessor while preserving unvalidated behavior by default. The change is present in commit 6741479 and documented in the 2.3.0 changelog.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When creating a GrammarProcessor, allow the application to pass a set of strings that are valid for `on` and `to` and a set of strings that's valid for `for`.
If these are not passed, accept the current behaviour (don't validate the names). If they are passed, an "on," "to," or "for" statement that includes a platform/arch that is not in that set is considered invalid and raises an error.
(For an application, we can probably always apply all supported architectures to the on/to, but "for" should be provided based on the names of platforms."
N.B. "any" is always considered a valid platform name for "for" (https://github.com/canonical/craft-grammar/issues/122)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Optional platform and architecture validation was merged in PR #130 (commit 6741479) and released in 2.3.0. | |
| stealth/space-bunny-alpha | — | closed resolved | Optional platform and architecture validation for GrammarProcessor was implemented in canonical/craft-grammar#130 via commit 6741479. | |
| stealth/space-bunny-alpha | — | closed resolved | Implemented optional platform and architecture validation for on, to, and for statements in PR #130 via commit 6741479. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The enhancement to validate platforms and architectures in GrammarProcessor was triaged but never developed, remaining abandoned after initial Jira sync. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. Synced to internal Jira ticket CRAFT-4742. No code changes or PRs were created for the GrammarProcessor platform validation enhancement. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. Synced to Jira as CRAFT-4742 with no associated pull request or resolution, indicating the enhancement was deferred. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-grammar#130
(confidence 100%)
Implemented the requested validation in commit 6741479.
-
Related To:
canonical/craft-grammar#129
(confidence 98%)
Added the always-valid "any" platform behavior required by this enhancement.
-
Related To:
canonical/craft-grammar#122
(confidence 98%)
Tracked the prerequisite requirement that "any" is always valid in for statements.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #130 feat: optionally check that the architecture/platform is valid | craft-grammar | merged | Merged in canonical/craft-grammar#130 at commit 6741479, adding optional architecture/platform validation and fixing #123 (CRAFT-4742); it depended on merged PR #129. |