feat(for-grammar): add an 'else' clause
Metadata
Current evaluation
Merged PR #137 in commit db3217b, adding else-clause support to for grammar as requested in #134; nested else contents remain unprocessed.
Resolution: closed resolved
Reason: PR #137 was merged with all CI checks passing, resolving issue #134. The merged implementation aligns for grammar with to grammar, although recursive processing of else-clause contents remains unsupported.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This allows `for` grammar to work like `to` grammar in terms of having an else clause. However, like in `to` grammar, this does not yet recursively process the contents of the `else` clause.
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Fixes #134
CRAFT-4768
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #137 in commit db3217b, adding else-clause support to for grammar as requested in #134; nested else contents remain unprocessed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged else-clause support for craft-grammar's for grammar, matching to grammar; nested else contents remain unprocessed. Fixes #134 (CRAFT-4768). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds an else clause to the for grammar, matching to grammar behavior without recursive processing. Approved by two reviewers, passed CI checks, and resolves #134 and CRAFT-4768. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
craft-grammar#134
(confidence 100%)
PR #137 explicitly states that it fixes #134 for CRAFT-4768.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #134 `for` grammar: support `else` statement | craft-grammar | closed | Added for-grammar else support in merged PR #137 (commit db3217b); nested grammar inside else remains unparsed as a known limitation. | |
| #125 `for` grammar: support `else on` and `else for` | craft-grammar | open | Maintainer-filed enhancement to add `else on` and `else for` clauses to the `for` grammar, with example YAML. Still open after plain `else` support landed in commit db3217b (#137); no discussion beyond an autogenerated Jira link. |