← Back to issue list

feat(for-grammar): add an 'else' clause

View original Github issue

Metadata

Project
craft-grammar
Number
#137
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Adds an else clause to the for grammar, matching to grammar behavior without recursive processing. Approved by two reviewers, passed CI checks, and resolves #134 and CRAFT-4768.

Suggested action: —

No scores available.

Issue body

This allows `for` grammar to work like `to` grammar in terms of having an else clause. However, like in `to` grammar, this does not yet recursively process the contents of the `else` clause. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Fixes #134 CRAFT-4768

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Adds an else clause to the for grammar, matching to grammar behavior without recursive processing. Approved by two reviewers, passed CI checks, and resolves #134 and CRAFT-4768.
qwen3.6-35b-a3b-mtp-q6 — — Merged feature adding an else clause to the for grammar, aligning with the to grammar's non-recursive behavior. Closes #134 and CRAFT-4768. Author scheduled a release with a changelog entry.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#125 `for` grammar: support `else on` and `else for` craft-grammar open Enhancement to support `else on` and `else for` statements in the `for` grammar, extending the existing `else` clause. Triaged by maintainer and tracked in Jira (CRAFT-4744); not yet implemented in the processor.
76%
#134 `for` grammar: support `else` statement craft-grammar closed Closed without implementation. No resolution or merge details were provided. The enhancement to add an else statement to the for grammar appears abandoned after initial triage and Jira synchronization.
74%
#108 feat: add 'for' statement craft-grammar merged Merged. Implemented a for statement in craft-grammar, adding integration tests per reviewer feedback. CI passed and three reviewers approved. Minor null-handling feedback was deferred to future issues.
72%