← Back to issue list

models: fix grammar validation

View original Github issue

Metadata

Project
craft-grammar
Number
#6
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged fix for grammar validation. Updated validators to correctly process a list of one-entry dictionaries instead of a single dictionary. Approved, passed CI, and integrated as a follow-up to PR #4.

Suggested action:

No scores available.

Issue body

Grammar is expressed as a list of one-entry dictionaries. Previous code validated it as a dictionary, so fix the validators to use the correct data structures. This is a follow-up to PR #4 (CRAFT-856). **Note to reviewers:** please make sure that the yaml definition in `test_validate_grammar_recursive` is syntactically correct. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for grammar validation. Updated validators to correctly process a list of one-entry dictionaries instead of a single dictionary. Approved, passed CI, and integrated as a follow-up to PR #4.
qwen3.6-35b-a3b-mtp-q6 Merged a fix updating grammar validators to correctly process a list of one-entry dictionaries instead of a single dictionary. Recursive processing remains enabled to prevent migration issues.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#74 fix: handle multi-entry dictionary after grammar statement craft-grammar merged Merged a fix for handling multi-entry dictionaries after grammar statements, resolving issue #73. Approved by two reviewers, the update modified three files with a net addition of 18 lines.
71%