fix: use the origin type when validating a grammar list
Metadata
Current evaluation
Merged in commit aea0ab4, PR #82 fixed #81 by validating grammar-list elements against their origin type, restoring Python 3.13 GenericAlias compatibility.
Resolution: closed resolved
Reason: PR #82 was approved and merged as commit aea0ab4. Its fix uses the generic type's origin before issubclass validation, resolving the Python 3.13 incompatibility reported in #81.
Evaluated by: mr-cal-bot
No scores available.
Issue body
issubclass working on a GenericAlias was a bug that was fixed in python 3.13 (see https://github.com/python/cpython/issues/101162)
Fixes #81
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit aea0ab4, PR #82 fixed #81 by validating grammar-list elements against their origin type, restoring Python 3.13 GenericAlias compatibility. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-grammar#82, fixing #81 by validating grammar-list items with their origin type so issubclass works with GenericAlias on Python 3.13. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to resolve issue #81. The change fixes issubclass handling for GenericAlias objects, aligning with Python 3.13 behavior. Approved by two reviewers, passed CI, and applied with a two-line modification. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-grammar#81
(confidence 100%)
Python 3.13 incompatibility explicitly fixed by merged PR #82.
-
Related To:
cpython#101162
(confidence 95%)
Upstream Python fix for calling issubclass with a GenericAlias.
Related issues
No related issues found above the similarity threshold.