← Back to issue list

packages: remove sudo calls (CRAFT-384)

View original Github issue

Metadata

Project
craft-parts
Number
#100
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged. Removed unnecessary sudo calls from apt and snap installation commands, causing execution to fail if permissions are insufficient. Approved after passing CI checks, with a reviewer noting a future explicit root check will be added.

Suggested action:

No scores available.

Issue body

Remove sudo calls from apt and snap install calls, and fail instead if permission to run is insufficient. Sudo is not necessary in the provider environment because the application already runs as root. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Removed unnecessary sudo calls from apt and snap installation commands, causing execution to fail if permissions are insufficient. Approved after passing CI checks, with a reviewer noting a future explicit root check will be added.
qwen3.6-35b-a3b-mtp-q6 Removed sudo calls from apt and snap installation commands and merged. Application runs as root in the provider environment, making sudo redundant. Fails if permissions are insufficient; reviewer noted a future root check may be added.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#228 packages: run snap operations silently craft-parts merged Merged to fix #218 by running snap subprocesses silently, preventing stdout leakage that conflicts with craft-cli during lifecycle execution. Approved by one reviewer, passed CI, and modified two files (+32/-15 lines).
70%
#2281 build providers: re-exec as root snapcraft merged Merged changes to re-execute snapcraft as root when invoked from a managed-host environment, resolving Launchpad bug #1791977. Approved by a reviewer, passed CI checks, and modified one file with 13 additions.
70%