← Back to issue list

fix(util/process): collect complete output from subprocess

View original Github issue

Metadata

Project
craft-parts
Number
#1036
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1036 (commit a80be133) fixes #1025: util/process now runs the subprocess read loop one final time before exiting, so combined output is no longer truncated. Approved by 2 reviewers; verified by mr-cal in snapcraft#5292.

Resolution: closed resolved

Reason: The PR was merged into the main branch with two approvals and no unresolved review comments, closing issue #1025 ('Python plugin fails intermittently to find an interpreter'). The fix makes the combined-output loop perform one last read before exiting so callers receive complete subprocess output; mr-cal confirmed the behaviour in canonical/snapcraft#5292.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Run subprocess output one last time before exiting the combined output processing loop. Fix #1025 - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1036 (commit a80be133) fixes #1025: util/process now runs the subprocess read loop one final time before exiting, so combined output is no longer truncated. Approved by 2 reviewers; verified by mr-cal in snapcraft#5292.
stealth/space-bunny-alpha — closed resolved Merged fix for #1025: util/process now collects subprocess output one final time before exiting the combined-output loop. Approved by two reviewers with no unresolved comments.
qwen/qwen3.6-35b-a3b — — Merged pull request fixing issue #1025 by collecting complete subprocess output before the processing loop exits. Approved by two reviewers, passed CI, and implemented with a minor change (+9/-1 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged fix that collects complete subprocess output by running the processing loop one final time before exit. Resolves #1025.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1025 (confidence 100%)

    Tracking issue for intermittent interpreter lookup failure, closed by this PR's merge (commit a80be133).

  • Related To: canonical/snapcraft#5292 (confidence 85%)

    Downstream instrumentation PR where mr-cal verified the fix works; closed unmerged as redundant afterwards.

Related issues

No related issues found above the similarity threshold.