← Back to issue list

Plugin integration tests should test for re-entrancy

View original Github issue

Metadata

Project
craft-parts
Number
#1041
Type
issue
State
open
Author
mr-cal
Labels
Status: Triaged Type: Enhancement
Created
Updated
Closed

Current evaluation

Enhancement to add plugin integration tests verifying re-entrancy (running builds multiple times and detecting source updates), motivated by the uv plugin bug fixed in PR #956. Triaged by maintainer, tracked in JIRA CRAFT-4324, but no integration re-entrancy tests have been added since.

Suggested action: keep open

Reason: The issue is properly triaged (Status: Triaged, Type: Enhancement labels, JIRA ticket CRAFT-4324 created) and the underlying problem is real — PR #956 'fix: make uv plugin re-entrant on code changes' was merged to address a re-entrancy bug, confirming the need for such tests. However, no integration tests for re-entrancy have been added since (only unit tests like test_get_build_commands_is_reentrant exist for cargo and maven plugins), so the enhancement remains unaddressed. The issue is stale (536 days, no activity) but still relevant as a test coverage gap.

Impact: 50 Quick Win: 22.5 Staleness: 75 Complexity: 55 Confidence: 70 Support Request: 5

Issue body

### What needs to get done The plugin integration tests should test that they can: * be run multiple times * source updates are not ignored ### Why it needs to get done To test and detect problems like https://github.com/canonical/craft-parts/pull/956/

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 50
Quick Win: 22.5
Staleness: 75
Complexity: 55
Confidence: 70
Support Request: 5
keep open Enhancement to add plugin integration tests verifying re-entrancy (running builds multiple times and detecting source updates), motivated by the uv plugin bug fixed in PR #956. Triaged by maintainer, tracked in JIRA CRAFT-4324, but no integration re-entrancy tests have been added since.
qwen/qwen3.6-35b-a3b
Staleness: 90
Complexity: 40
Confidence: 85
Support Request: 5
close stale Enhancement to add re-entrancy checks to plugin integration tests, preventing ignored source updates. Triaged but inactive for over a year, with only an automated Jira sync comment.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 30
Confidence: 75
Support Request: 0
close stale Enhancement to add re-entrancy tests to the plugin integration suite, ensuring multiple runs and update sourcing work correctly. Triaged but inactive for over a year with no implementation progress.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 35
Confidence: 80
Support Request: 0
keep open Triaged enhancement requesting plugin integration tests verify re-entrancy, including multiple runs and source update handling. Linked to Jira ticket, awaiting implementation.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/craft-parts#956 (confidence 90%)

    PR #956 'fix: make uv plugin re-entrant on code changes' was the motivating bug that prompted this enhancement request for re-entrancy integration tests.

Related issues

No related issues found above the similarity threshold.