← Back to issue list

feat: maven plugin enhancement

View original Github issue

Metadata

Project
craft-parts
Number
#1050
Type
pull request
State
closed
Author
yanksyoon
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; Maven Wrapper support was split into #1054 and merged as 3503ab9b. Java version validation was not accepted.

Resolution: closed superseded

Reason: A maintainer requested splitting Maven Wrapper support into a separate PR. That work landed through #1054 in commit 3503ab9b, while the Java version validation portion was not accepted.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; Maven Wrapper support was split into #1054 and merged as 3503ab9b. Java version validation was not accepted.
stealth/space-bunny-alpha — closed superseded Closed unmerged after review; Maven Wrapper support was split into canonical/craft-parts#1054 and merged as 3503ab9b. Java version validation was not accepted in this PR.
qwen/qwen3.6-35b-a3b — — Closed without merging. Reviewer requested splitting the maven wrapper and Java version validation features into separate PRs. The changes remain abandoned with 41 unresolved review comments.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merge. Maintainer requested splitting the maven plugin enhancements into separate PRs for maven wrapper support and java version validation. Changes were abandoned pending resubmission.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#1054 (confidence 99%)

    Merged replacement for the Maven Wrapper portion of this unmerged PR.

Related issues

Issue Project State Summary Similarity
#1032 feat: spring boot plugin craft-parts closed Closed unmerged for a plugin redesign; Maven-wrapper support landed in #1054 (3503ab9b), and a separate Gradle plugin landed in #1056 (87e494f5).
81%
#728 feat: maven rockcraft plugin rockcraft closed Closed unmerged and superseded by #752 (commit b7ea7434), which added Maven/Ant overrides avoiding conflicting /bin/java symlinks.
79%
#1054 feat: use-mvnw support craft-parts merged Merged in #1054 (commit 3503ab9b), adding maven-use-wrapper support for building with a checked-in ./mvnw instead of system Maven. Released in 2.8.0.
76%
#1125 feat: maven-use plugin craft-parts merged Merged #1125 as b86a3910, productizing the maven-use plugin for CRAFT-4570; all CI checks passed.
74%