← Back to issue list

test: fix directory test strategy

View original Github issue

Metadata

Project
craft-parts
Number
#1077
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1077 (a45a78ad) fixed the directory test strategy so generated partitions cannot duplicate the "default" name.

Resolution: closed resolved

Reason: PR #1077 was merged with all CI checks passing. Commit a45a78ad corrects the test strategy that could generate two partitions named "default".

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ----- Craft Parts would occasionally [fail](https://github.com/canonical/craft-parts/actions/runs/14618175587/job/41011179284?pr=1073#step:8:211) when the strategy generated "default" because there would be 2 partitions named "default".

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1077 (a45a78ad) fixed the directory test strategy so generated partitions cannot duplicate the "default" name.
stealth/space-bunny-alpha — closed resolved Merged PR #1077 as commit a45a78ad, fixing directory test partition naming to prevent duplicate partitions named "default".
stealth/space-bunny-alpha — closed resolved Merged as a45a78ad, correcting the directory test strategy to avoid creating two partitions named "default" and causing intermittent test failures.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/craft-parts#1077 as commit a45a78ad, fixing the directory test strategy so it no longer generates duplicate partitions named "default".
qwen/qwen3.6-35b-a3b — — Merged a fix for the directory test strategy that prevented Craft Parts failures when two partitions shared the default name. The change passed all CI checks, received reviewer approval, and updated the changelog.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the directory test strategy that resolved Craft Parts failures caused by duplicate default partition names. The update corrects the test configuration to ensure unique partition identifiers.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#624 test: use `new_dir` fixture craft-parts merged Merged PR #624 as commit d214d9d8, updating two unit tests to use new_dir so test files no longer pollute the repository working directory.
70%