← Back to issue list

utils: add filesystem mounting calls (CRAFT-460)

View original Github issue

Metadata

Project
craft-parts
Number
#109
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #109 (CRAFT-460) by cmatsuoka was merged (commit 5e70026e), adding mount()/umount() wrappers around /bin/mount and /bin/umount in craft_parts/utils/os_utils.py for the overlay feature.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged into main via commit 5e70026e; its changes (commits a1f4ff04 'utils: add filesystem mounting calls' and e021c791) are present in craft_parts/utils/os_utils.py, where mount() and umount() still exist today.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add utilities to mount and unmount filesystems. These are thin wrappers around the system mount and umount commands. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #109 (CRAFT-460) by cmatsuoka was merged (commit 5e70026e), adding mount()/umount() wrappers around /bin/mount and /bin/umount in craft_parts/utils/os_utils.py for the overlay feature.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#109 (commit a1f4ff04), adding mount and unmount wrappers around the system mount and umount commands for CRAFT-460.
stealth/space-bunny-alpha — closed resolved Merged thin mount and umount filesystem utility wrappers for CRAFT-460; approved by two reviewers despite one unresolved review comment.
qwen/qwen3.6-35b-a3b — — Merged to introduce filesystem mount and unmount utilities as thin wrappers around system commands. Approved by two reviewers, passed CI, and added 38 lines across two files to resolve CRAFT-460.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Introduces thin wrapper utilities for system mount and umount commands, resolving CRAFT-460. Authored by maintainer cmatsuoka.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#127 (confidence 85%)

    Follow-up overlay manager mount operations (commits d8bc12b5, 95f19f73, 04faa535, 14f25785) build directly on these mount/umount utilities.

  • Related To: craft-parts#183 (confidence 60%)

    Commit 27f1bf23 'overlays: mount overlayfs using fuse-overlayfs' extended these utilities with mount_overlayfs().

Related issues

Issue Project State Summary Similarity
#111 overlay: add overlayfs helpers (CRAFT-462) craft-parts merged Merged PR #111 via commit 7424a039, adding OverlayFS mount/unmount helpers and detection for special files and directories used in filesystem layering.
77%