← Back to issue list

feat: convert FilesystemMounts to a class

View original Github issue

Metadata

Project
craft-parts
Number
#1108
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1108 as commit 620b18d3, converting FilesystemMounts to a Pydantic class so LifecycleManager validates and stores a proper object.

Resolution: closed resolved

Reason: PR #1108 was approved with all CI checks passing and merged into main as commit 620b18d3. The change adds Pydantic validation for FilesystemMounts during LifecycleManager initialization.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ----- Convert the FilesystemMounts type annotation to a pydantic class. This is used when initializing the LifecycleManager to make sure a proper object is stored.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1108 as commit 620b18d3, converting FilesystemMounts to a Pydantic class so LifecycleManager validates and stores a proper object.
stealth/space-bunny-alpha — closed resolved Merged PR #1108 converts FilesystemMounts into a Pydantic class, ensuring LifecycleManager initialization stores a validated object.
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers and passing CI checks. Converts the FilesystemMounts type annotation to a Pydantic class to ensure proper object initialization in LifecycleManager. Modifies three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged conversion of FilesystemMounts to a Pydantic class, ensuring proper object initialization and validation during LifecycleManager setup.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1100 feat: add Filesystem model craft-parts merged Merged PR #1100 as commit 67c82a74, adding FilesystemMount models and filesystems support to LifecycleManager and ProjectInfo for partition-overlay content distribution.
72%