← Back to issue list

refactor: generalize settings file generation for the maven plugin

View original Github issue

Metadata

Project
craft-parts
Number
#1120
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged a refactoring generalizing Maven settings generation into a shared utilities module for the maven-use plugin. Also fixes a circular import in craft_parts. Approved and passed all CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ----- Upstreams the generation of the Maven settings file to a Maven utilities file in preparation for the maven-use plugin. I followed the lead of how the settings file was generated in [this branch](https://github.com/canonical/craft-parts/blob/4cc452ee31c99f79d96635d2bcc2ed765e7de12b/craft_parts/plugins/_maven_util.py). The change in `craft_parts/__init__.py` was to fix a circular import error when directly importing `craft_parts.infos`. CRAFT-4569

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactoring generalizing Maven settings generation into a shared utilities module for the maven-use plugin. Also fixes a circular import in craft_parts. Approved and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged refactoring generalizing Maven settings file generation into a shared utility module. Also resolves a circular import error in craft_parts/__init__.py. Closes CRAFT-4569.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.