refactor: generalize settings file generation for the maven plugin
Metadata
Current evaluation
Merged as b74d608e: PR #1120 generalized Maven settings generation into shared utilities, fixed a circular import, and prepared support for the Maven-use plugin.
Resolution: closed resolved
Reason: PR #1120 was approved with all CI checks passing and merged as commit b74d608e. The refactor moved settings generation into shared Maven utilities and corrected the craft_parts import cycle.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
-----
Upstreams the generation of the Maven settings file to a Maven utilities file in preparation for the maven-use plugin. I followed the lead of how the settings file was generated in [this branch](https://github.com/canonical/craft-parts/blob/4cc452ee31c99f79d96635d2bcc2ed765e7de12b/craft_parts/plugins/_maven_util.py).
The change in `craft_parts/__init__.py` was to fix a circular import error when directly importing `craft_parts.infos`.
CRAFT-4569
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as b74d608e: PR #1120 generalized Maven settings generation into shared utilities, fixed a circular import, and prepared support for the Maven-use plugin. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1120 as b74d608e, moving Maven settings generation into shared utilities and fixing a craft_parts.infos circular import. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1120 as commit b74d608e, generalizing Maven settings generation into shared utilities and fixing a circular import in craft_parts. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactoring generalizing Maven settings generation into a shared utilities module for the maven-use plugin. Also fixes a circular import in craft_parts. Approved and passed all CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring generalizing Maven settings file generation into a shared utility module. Also resolves a circular import error in craft_parts/__init__.py. Closes CRAFT-4569. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#1125
(confidence 96%)
The subsequent maven-use plugin PR used the generalized Maven utilities enabled by #1120.
Related issues
No related issues found above the similarity threshold.