feat: improve error messages when parsing XML
Metadata
Current evaluation
Merged PR #1138 as commit 281cb7d8, improving maven-use XML parse errors by displaying the full offending XML element for easier debugging.
Resolution: closed resolved
Reason: PR #1138 was merged into main as commit 281cb7d8. The change enriches malformed-XML diagnostics by printing the entire offending element because line numbers are unavailable.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
-----
Improves the error message given when parsing bad XML with the maven-use plugin. Previously, very empty error messages were given that gave next to no information for finding the offending XML tag. Now, the entire XML element is printed (as line numbers are not available to us) to aid in debugging.
CRAFT-4601
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1138 as commit 281cb7d8, improving maven-use XML parse errors by displaying the full offending XML element for easier debugging. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR improved maven-use XML parsing errors by printing the full offending element, adding diagnostic context; 11 review comments remain unresolved. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged enhancement improving XML parsing error messages in the maven-use plugin. Replaces unhelpful empty errors with full XML element output for debugging. Approved by two reviewers, passed all CI checks, and modified 5 files (+47/-14). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvement to XML parsing error messages in the maven-use plugin. The change prints the full offending XML element instead of empty messages to aid debugging, addressing CRAFT-4601. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1172 refactor(maven-use): use lxml instead of base xml for all parsing | craft-parts | merged | Merged PR #1172 as commit 215eafd4, replacing standard-library XML parsing throughout maven-use with hardened lxml parsing and cleaner XML handling. | |
| #192 feat: add Maven POM inspector | fetch-service | merged | Merged PR #192 as commit 8a6ca8b, adding a Maven POM inspector that inspects downloaded dependency POMs and fixes #168. |