← Back to issue list

feat: symlinks for aliased partition to default dirs

View original Github issue

Metadata

Project
craft-parts
Number
#1164
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1164 in commit 6745b24b, adding default-directory symlinks and correct stage-package priming for aliased default partitions, with fixture and test coverage.

Resolution: closed resolved

Reason: PR #1164 was approved and merged as 6745b24b, implementing the partition symlinks, package priming, and test coverage. Its remaining failure was tracked in #1171 and fixed by #1185 (11eca6ee), released in craft-parts 2.19.0.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ----- When using an alias for the default partition, create symlinks for this partition targeting the default directories in the working directories. Properly prime stage packages when the default partition is aliased. Add a fixture case with an aliased default partition and fix tests to properly handle it.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1164 in commit 6745b24b, adding default-directory symlinks and correct stage-package priming for aliased default partitions, with fixture and test coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #1164 (commit 6745b24b) added symlinks for aliased default partitions, fixed stage package priming, and added fixture and test coverage.
qwen/qwen3.6-35b-a3b — — Merged to implement symlinks for aliased default partitions, fix stage package priming, and update tests. The author proceeded despite failing CI, attributing failures to an external issue (#1171). Approved by three reviewers.
qwen3.6-35b-a3b-mtp-q6 — — Merged after adding symlinks for aliased default partitions to default directories and fixing stage package priming. The change proceeded despite a known test failure tracked in issue #1171, following a minor typo fix.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1171 (confidence 100%)

    Remaining test failure after #1164 was attributed to this missing CRAFT_DEFAULT_* environment-variable bug.

  • Related To: canonical/craft-parts#1185 (confidence 100%)

    Merged as 11eca6ee to resolve #1171 and ensure CRAFT_DEFAULT_* variables are set for an aliased default partition.

Related issues

No related issues found above the similarity threshold.