← Back to issue list

feat(jlink): introduce add_modules parameter

View original Github issue

Metadata

Project
craft-parts
Number
#1169
Type
pull request
State
merged
Author
vpa1977
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1169 added jlink-extra-modules, allowing dynamically loaded modules such as jdk.crypto.ec to be included in Java 8 images.

Resolution: closed resolved

Reason: PR #1169 was merged and implemented by commit ddcc1e2e. The feature was documented in the craft-parts 2.20.0 changelog.

Evaluated by: mr-cal-bot

No scores available.

Issue body

When building Java 8 (non-modular) applications we can not specify required modules through module-info.java. This makes it impossible to include security provider module `jdk.crypto.ec` in Java 8 application since it is dynamically loaded and not picked up by jdeps. `jlink-extra-modules` parameter specifies such modules explicitly without upgrading application to Java 11+ (introducing application modules). - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1169 added jlink-extra-modules, allowing dynamically loaded modules such as jdk.crypto.ec to be included in Java 8 images.
stealth/space-bunny-alpha — closed resolved Merged PR #1169, adding jlink extra_modules to explicitly include dynamically loaded modules such as jdk.crypto.ec in Java 8 builds. Implemented by commit ddcc1e2e.
qwen/qwen3.6-35b-a3b — — Merged. Introduces the add_modules parameter for jlink, enabling explicit inclusion of dynamically loaded modules in Java 8 applications lacking module-info.java. Approved by three reviewers, passed all CI checks, and resolved initial unit test failures prior to merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds the add_modules parameter to jlink, enabling explicit inclusion of dynamically loaded modules like jdk.crypto.ec in Java 8 apps without Java 11. The change was accepted after the reported unit test failure was resolved.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.