← Back to issue list

plugins: fix plugin properties test (CRAFT-483)

View original Github issue

Metadata

Project
craft-parts
Number
#117
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged fix for CRAFT-483 correcting instance assignment to the plugin properties class variable in tests. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

Fix assignment of instance to plugin properties class variable. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for CRAFT-483 correcting instance assignment to the plugin properties class variable in tests. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged correction to plugin properties test that fixes instance assignment to the class variable, resolving CRAFT-483.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#71 plugins: check presence of required part properties (CRAFT-74) craft-parts merged Merged after two approvals and passing CI. Replaces manual verification of required plugin properties, such as source, with Pydantic validation. Updated nine files (+78/-25 lines) to enforce property requirements during plugin configuration.
75%
#101 plugins: strip plugin properties in non-destructive way (CRAFT-394) craft-parts merged Merged a change to strip plugin properties non-destructively, preventing mutation of original parts data. Approved by one reviewer, passed CI, and modified five files.
73%
#608 docs: add note about plugin-specific properties craft-parts merged Merged documentation update adding a note about plugin-specific property requirements. Approved by two reviewers, passed CI checks, and contained no unresolved comments.
72%
#1286 test: run all plugin tests with partitions craft-parts merged Merged after two approvals and passing CI. The change refactors plugin test execution to run all tests with partitions enabled across 26 files. Resolves CRAFT-4767.
71%
#22 plugins: add plugin and plugin properties base classes craft-parts merged Merged: introduces base classes for the plugin subsystem and plugin properties. Approved by three reviewers, passed CI checks, and added 227 lines across six files to define part source building with optional plugin-specific properties.
71%
#77 tests: add integration tests for application plugins (CRAFT-69) craft-parts merged Merged integration tests for application plugins. Approved by two reviewers, passed CI checks, and added 203 lines across two files to verify plugin registration and functionality.
71%
#249 fix: rename plugin to plugin_name craft-parts merged Merged a fix renaming the plugin variable to plugin_name to accurately represent it as a string rather than a Plugin object. The change was approved, passed CI checks, and modified five files.
70%