← Back to issue list

overlay: migrate overlay data to stage and prime (CRAFT-468, CRAFT-82)

View original Github issue

Metadata

Project
craft-parts
Number
#121
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #121 as d45d7079, moving overlay data into stage/prime, translating whiteouts and opaque directories to OCI, and cleaning shared overlay data.

Resolution: closed resolved

Reason: PR #121 was approved and merged into main by d45d7079, with implementation commit 29a0c5ed adding overlay migration and OCI translation. Its explicitly deferred collision detection was merged separately in PR #1190.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Migrate overlay tree entries to stage and prime areas, handling whiteouts and translating overlayfs whiteout files and opaque directories to OCI. Cleanup of overlay files in shared areas is done when the last part with overlay parameters is cleaned. Note: collision detection in overlay staging will be implemented in a forthcoming PR. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #121 as d45d7079, moving overlay data into stage/prime, translating whiteouts and opaque directories to OCI, and cleaning shared overlay data.
stealth/space-bunny-alpha — closed resolved Merged craft-parts#121 in d45d7079, migrating overlay data to stage/prime, converting overlayfs whiteouts and opaque directories to OCI, and cleaning shared areas.
qwen/qwen3.6-35b-a3b — — Merged after two approvals and CI. Migrates overlay data to stage and prime, translates overlayfs whiteouts and opaque directories to OCI, and cleans shared areas. Collision detection is deferred.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation migrating overlay tree entries to stage and prime areas, handling whiteouts, translating to OCI, and managing cleanup. Overlay staging collision detection will be implemented separately.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#1190 (confidence 98%)

    Referenced follow-up for overlay collision detection, merged as b7455277.

  • Related To: craft-parts#1208 (confidence 82%)

    Follow-up cleanup work for overlay directories, merged as bea8d2dc.

Related issues

Issue Project State Summary Similarity
#1617 fix: migrate overlay files before running stage or prime craft-parts merged Merged #1617 as 2d81a4bd, moving overlay migration before stage/prime so build-created directories cannot shadow overlay state and break priming; regression coverage was added.
82%
#1619 fix: migrate overlay files before running stage or prime (#1617) craft-parts merged Merged as bf3615ca, cherry-picking #1617 so overlay files migrate before stage or prime, preventing build-created directories from shadowing overlay state and breaking priming.
80%
#119 overlay: add overlay hash to build and stage states (CRAFT-489) craft-parts merged Merged PR #119 for CRAFT-489, adding overlay hashes to build and stage states so overlay-dependent steps are correctly invalidated; merge commit af08815b.
76%
#111 overlay: add overlayfs helpers (CRAFT-462) craft-parts merged Merged PR #111 via commit 7424a039, adding OverlayFS mount/unmount helpers and detection for special files and directories used in filesystem layering.
74%
#1123 fix: Prime content from overlay when split into partitions craft-parts merged Merged PR #1123 (commit 3540e306), fixing overlay priming with partitions by using stage content and migration state while preserving existing prime state files.
73%
#115 overlay: add layer visibility helpers (CRAFT-477) craft-parts merged Merged PR #115 in commit 0cd9d342, adding overlay layer visibility helpers that account for whiteout entries and opaque directories.
72%
#113 overlay: add overlay support to parts (CRAFT-470) craft-parts merged Merged #113 via commit 2d90e608, adding overlay work-directory definitions, overlay subdirectory properties, and detection of overlay parameters and visibility for CRAFT-470.
72%
#127 overlay: add overlay manager mount operations (CRAFT-80) craft-parts merged Merged #127 via commit 95f19f73 (merge c984efb8), adding overlay-manager mount operations; package installation was deferred to a separate change.
71%
#370 docs: explanation section for overlays craft-parts merged Merged PR #370 as commit a90caeb4, adding overlay documentation and incorporating #365’s lifecycle changes; it resolved CRAFT-1560.
71%
#1190 fix(overlay): detect conflicts between overlay and install craft-parts merged Merged PR #1190 fixed Stage collision detection by including overlay layer contents and added integration tests for colliding and non-colliding scenarios in commit b7455277.
71%