feat(maven-use): improve selection when rewriting version numbers
Metadata
Current evaluation
Merged improvement to Maven version selection logic during rewrites. Approved by three reviewers and passed all CI checks. Adds full test coverage and documents edge cases across five files to handle arbitrary strings.
Suggested action: —
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
-----
The logic for this is unfortunately quite messy since I'm dealing with potentially arbitrary strings, but I tried to ensure each code path was documented and had full test coverage. I'm open to adding more tests if some edge cases are thought of.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged improvement to Maven version selection logic during rewrites. Approved by three reviewers and passed all CI checks. Adds full test coverage and documents edge cases across five files to handle arbitrary strings. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enhances Maven version number selection during rewriting with documented logic for arbitrary strings. Includes full test coverage and incorporates reviewer feedback on accuracy. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1285 docs: add docs on maven's version rewriting feature | craft-parts | merged | Merged documentation update detailing Maven's version rewriting feature in the maven-use plugin. Approved by two reviewers, passed all CI checks, and added 26 lines explaining the updated version selection logic. | |
| #1147 feat(maven-use): add support for the parent tag | craft-parts | merged | Merged. Adds support for rewriting the parent tag version in pom.xml files for the maven-use tool. Approved by three reviewers, passed all CI checks, and implemented across eight files (+69/-2 lines). Resolves CRAFT-4602. | |
| #1155 feat(maven-use): handle indirect plugin dependencies | craft-parts | merged | Merged changes fix Maven indirect plugin dependency handling by scanning available plugins on disk and adding explicit pins via pluginManagement, replacing hard-coded default versions. Approved by three reviewers with all CI checks passing. | |
| #1125 feat: maven-use plugin | craft-parts | merged | Merged the maven-use plugin, productizing it per CRAFT-4570. Approved by three reviewers and passed all CI checks. The update modified 21 files, adding 1505 lines and removing 136. | |
| #1166 feat(maven-use): support multi-module projects | craft-parts | merged | Merged. Implements recursive discovery and patching for nested pom.xml files in multi-module Maven projects via the maven-use plugin. Approved by three reviewers, passed all CI checks, and modified 11 files. | |
| #1139 fix(maven-use): always set version | craft-parts | merged | Merged a fix for the maven-use plugin that automatically assigns an available version to dependencies when unspecified, preventing errors. Approved by three reviewers and passed all CI checks across multiple Python and OS environments. |