← Back to issue list

Refactor repository method dispatching

View original Github issue

Metadata

Project
craft-parts
Number
#1259
Type
issue
State
open
Author
cmatsuoka
Labels
Status: Triaged Type: Enhancement
Created
Updated
Closed
—

Current evaluation

Maintainer-authored enhancement (JIRA CRAFT-4753) to replace the `_RepositoryProxy` in craft_parts/packages/__init__.py with top-level functions that resolve the repository internally. Triaged, still open; the proxy class is still present at HEAD.

Suggested action: keep open

Reason: The refactor target is confirmed still in place: `_RepositoryProxy` remains at craft_parts/packages/__init__.py:55 (introduced by ecceb40d / PR #1231, the very PR whose review comment the issue links), and a later commit bb62329e (#1294) only added typing around it without removing it. The issue carries labels 'Status: Triaged' and 'Type: Enhancement' and the sync bot created internal ticket CRAFT-4753, confirming maintainer ownership and intent, so it should stay open rather than be closed as resolved or stale.

Evaluated by: mr-cal-bot

Impact: 20 Quick Win: 7 Complexity: 48 Confidence: 84 Actionability: 72

Issue body

### What needs to get done Instead of using a proxy class for deferred repository detection, use top level methods resolving the repository internally. See https://github.com/canonical/craft-parts/pull/1231#discussion_r2321840994 ### Why it needs to get done Cleaner code.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 20
Quick Win: 7
Complexity: 48
Confidence: 84
Actionability: 72
keep open Maintainer-authored enhancement (JIRA CRAFT-4753) to replace the `_RepositoryProxy` in craft_parts/packages/__init__.py with top-level functions that resolve the repository internally. Triaged, still open; the proxy class is still present at HEAD.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 15
Complexity: 35
Confidence: 80
Actionability: 65
keep open Refactor _RepositoryProxy class into top-level methods for cleaner repository dispatching. Triaged enhancement from maintainer, still pending implementation.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 8
Staleness: 70
Complexity: 50
Confidence: 80
Support Request: 5
keep open Refactor _RepositoryProxy in craft_parts/packages to use top-level methods instead of a proxy class for deferred repository detection. Triaged enhancement, no PR created, proxy code still present in codebase.
qwen/qwen3.6-35b-a3b
Staleness: 75
Complexity: 45
Confidence: 85
Support Request: 0
keep open Enhancement to refactor repository method dispatching by replacing a proxy class with top-level methods. Triaged by a maintainer, currently inactive for over 10 months, awaiting implementation.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 45
Confidence: 75
Support Request: 5
keep open Refactor repository method dispatching to replace a proxy class with top-level internal resolution methods. Issue is triaged and pending implementation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1231 (confidence 95%)

    PR 'feat: dynamically detect the package repository type' (merged as ecceb40d) introduced the _RepositoryProxy; the issue's requested change comes directly from review discussion_r2321840994 on that PR.

Related issues

No related issues found above the similarity threshold.