← Back to issue list

fix: allow organize to move special files

View original Github issue

Metadata

Project
craft-parts
Number
#1260
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a fix enabling file organization to handle character and block devices. Replaced standard shutil.move with a custom helper supporting device nodes. Approved by three reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

Standard library `shutil.move` doesn't handle character and block devices. Implement an improved `move` helper that can also move device nodes, and use it when organizing files. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix enabling file organization to handle character and block devices. Replaced standard shutil.move with a custom helper supporting device nodes. Approved by three reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a fix enabling file organization to handle character and block devices. Replaced shutil.move with a custom helper that supports device nodes, resolving the standard library limitation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1201 fix: handle trying to organize a file to itself craft-parts merged Merged fix for glob expansion causing file organization to move a file to itself. Added detection to skip identical paths before shutil.move. Includes refactor and comments for organize_files. Approved by three reviewers and passed all CI checks.
77%