← Back to issue list

fix: allow organize to move special files

View original Github issue

Metadata

Project
craft-parts
Number
#1260
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-parts#1260 via commit 9f185208, adding a device-aware move helper so organize can move character and block special files.

Resolution: closed resolved

Reason: Commit 9f185208 implements special-file handling for character and block devices and uses it when organizing files. PR #1260 was approved and merged with all CI checks passing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Standard library `shutil.move` doesn't handle character and block devices. Implement an improved `move` helper that can also move device nodes, and use it when organizing files. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#1260 via commit 9f185208, adding a device-aware move helper so organize can move character and block special files.
stealth/space-bunny-alpha — closed resolved Merged PR replaced shutil.move during file organization with a device-node-aware move helper, enabling character and block special files to be moved.
qwen/qwen3.6-35b-a3b — — Merged a fix enabling file organization to handle character and block devices. Replaced standard shutil.move with a custom helper supporting device nodes. Approved by three reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix enabling file organization to handle character and block devices. Replaced shutil.move with a custom helper that supports device nodes, resolving the standard library limitation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1219 Organize fails with character devices craft-parts closed Organize treated character/block device nodes as regular files. Fixed by PR #1260, merged as commit 9f185208, which adds a device-aware move/copy helper using os.mknod for character and block special files.
74%
#1366 Unhandled error when organizing a file to a directory where the file already exists craft-parts closed Fixed by merged PR canonical/craft-parts#1370 (commit 7fe7c84e), which checks whether an organize destination exists before moving files.
72%