← Back to issue list

fix(wheel): include craft_parts_docs in the wheel

View original Github issue

Metadata

Project
craft-parts
Number
#1284
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1284 (commit de525c33) restores the craft_parts_docs package in the wheel by explicitly listing it in setuptools package-dir, fixing missing docs package in 2.22.0; released in 2.22.1 (2025-09-10).

Resolution: closed resolved

Reason: The PR was approved by 3 reviewers and merged as commit de525c33, adding "craft_parts_docs" = "docs/common" under [tool.setuptools.package-dir] plus a NOTE about not merging starbase's auto-find. It closes issue #1283 and the changelog entry for 2.22.1 (2025-09-10) records "The wheel once again includes craft_parts_docs".

Evaluated by: mr-cal-bot

No scores available.

Issue body

This also adds a note about not using setuptools to find packages since we're intentionally overriding it. This will likely be something we need to check every time we merge starbase, so moving this to be right next to where starbase would add that paragraph should prevent this. Fixes #1283 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1284 (commit de525c33) restores the craft_parts_docs package in the wheel by explicitly listing it in setuptools package-dir, fixing missing docs package in 2.22.0; released in 2.22.1 (2025-09-10).
stealth/space-bunny-alpha — closed resolved Merged in #1284 (de525c33), explicitly including craft_parts_docs in wheels and documenting the intentional setuptools discovery override; fixes #1283.
qwen/qwen3.6-35b-a3b — — Merged to resolve issue #1283. The change fixes wheel packaging by explicitly including craft_parts_docs and adds a setuptools configuration note to prevent auto-discovery. Approved by three reviewers with all CI checks passing.
qwen3.6-35b-a3b-mtp-q6 — — Merged to resolve issue #1283 by including craft_parts_docs in the wheel distribution. The change also documents the intentional setuptools override near the starbase configuration to prevent future package discovery conflicts.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#1283 (confidence 98%)

    Issue "2.22.0 is missing the craft_parts_docs package" was closed by this PR.

Related issues

Issue Project State Summary Similarity
#1283 2.22.0 is missing the `craft_parts_docs` package craft-parts closed Fixed by merged PR #1284 (commit de525c33), which explicitly includes craft_parts_docs in the wheel.
80%