← Back to issue list

BUILD step of a part organizing to the overlay should invalidate overlay contents of following parts

View original Github issue

Metadata

Project
craft-parts
Number
#1291
Type
issue
State
open
Author
upils
Labels
—
Created
Updated
Closed
—

Current evaluation

craft-parts bug: when a part organizing to the overlay re-runs its BUILD step, dependent parts' OVERLAY steps should be invalidated and re-executed, but they are skipped. Filed by a maintainer from PR #1261 discussion; unlabelled, 0 comments, inactive ~1 year.

Suggested action: needs triage

Reason: The issue has no labels, no comments, and no maintainer response in ~354 days, so it has not been triaged. It is a genuine bug with a concrete reproducer (test_basic_lifecycle_actions in tests/integration/lifecycle/test_lifecycle_organize_to_overlay.py, where bar's OVERLAY is skipped as 'already ran' after foo's source changes) and is not stale-irrelevant: the overlay/organize feature is still actively developed (e.g. #1618, #1602), and the test file now encodes the expected UPDATE behavior for bar's OVERLAY step, suggesting the fix may be in progress or partially landed. Closing would be premature; a maintainer should confirm whether #1618 or the sequencer overlay-verification work already covers this.

Impact: 55 Quick Win: 19.25 Staleness: 75 Complexity: 65 Confidence: 60 Support Request: 5

Issue body

### Bug Description See discussion https://github.com/canonical/craft-parts/pull/1261/files#r2333141004 If the BUILD step of a part organizing to the overlay is run/updated, content in the layer of this part can be changed. Consequently, layers of part applied on top of this one must be invalidated and the OVERLAY step of these part re-executed. ### To Reproduce See `test_basic_lifecycle_actions` First run with: ``` parts: bar: after: [foo] plugin: nil foo: plugin: nil organize: '*': (overlay)/ ``` Then change it to: ``` parts: bar: after: [foo] plugin: nil foo: plugin: nil source: a.tar.gz organize: '*': (overlay)/ ``` The OVERLAY step of `bar` will be re-executed but it should. ### part yaml ```shell ``` ### Relevant log output ```shell N/A ```

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 55
Quick Win: 19.25
Staleness: 75
Complexity: 65
Confidence: 60
Support Request: 5
needs triage craft-parts bug: when a part organizing to the overlay re-runs its BUILD step, dependent parts' OVERLAY steps should be invalidated and re-executed, but they are skipped. Filed by a maintainer from PR #1261 discussion; unlabelled, 0 comments, inactive ~1 year.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 70
Confidence: 85
Support Request: 10
needs triage Bug report indicating that organizing files to the overlay during a part's BUILD step should invalidate and re-run OVERLAY steps for dependent parts. Currently unlabelled and inactive for over 300 days with no maintainer interaction.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 75
Confidence: 85
Support Request: 5
needs triage Missing overlay layer invalidation when a part's BUILD step changes. Unlabelled, unassigned, and inactive for 300 days with no maintainer response.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 60
Confidence: 85
Support Request: 10
needs triage Modifying a part that organizes to the overlay fails to invalidate subsequent parts' OVERLAY steps. Open 281 days with zero comments. Requires triage and assignment.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1261 (confidence 90%)

    Issue explicitly cites the PR #1261 review discussion (r2333141004) as the origin of this bug.

  • Related To: canonical/craft-parts#1618 (confidence 55%)

    Commit 18239b07 'fix: dependency handling when organizing to overlay (#1618)' touched the same test file and area; may partially or fully address the invalidation behavior.

Related issues

Issue Project State Summary Similarity
#1611 Extra part triggering stage step before overlay step craft-parts closed Closed after triage and logging as internal ticket CRAFT-5215. No fix was merged. The staging-before-overlay build order bug remains unresolved.
72%
#1261 feat: reorder steps if organizing to overlay craft-parts merged Merged after approval and passing CI checks. The update reorders build steps for overlay-organizing parts, ensuring content organization runs immediately after the overlay step to satisfy ST-158 requirements.
71%