fix: do not collide on "similar" symlinks between overlay and install dir
Metadata
Current evaluation
Merged PR #1314 (commit bff2fa08), fixing false collisions between equivalent absolute and relative symlinks in overlay and install directories; resolves #1293.
Resolution: closed resolved
Reason: PR #1314 was approved with all CI checks passing and merged as commit bff2fa08. Its collision-path fix was confirmed against the reported use case and closes craft-parts#1293.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Fixes #1293
CRAFT-4758
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1314 (commit bff2fa08), fixing false collisions between equivalent absolute and relative symlinks in overlay and install directories; resolves #1293. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1314 (commit bff2fa08) fixes false collision reports between equivalent absolute/relative symlinks in overlay and install dirs, closing #1293 (CRAFT-4758). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1314 (commit bff2fa08), fixing false symlink collisions between overlay and install directories and resolving #1293 (CRAFT-4758). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for symlink collisions between overlay and install directories. The author refactored paths_collide for Rockcraft compatibility. All CI checks passed, reviews were approved, and the change resolved issue #1293. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for symlink collision detection between overlay and install directories. Refactored the paths_collide API to maintain Rockcraft compatibility, resolving issue 1293 and CRAFT-4758 after successful testing and CI checks. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-parts#1293
(confidence 100%)
The PR explicitly fixes the overlay/build symlink collision reported in #1293.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1293 Bad symlink collisions between overlay and build | craft-parts | closed | Fixed by merged PR #1314 (commit bff2fa08): equivalent absolute and relative symlinks no longer trigger false overlay/install collision errors. | |
| #1190 fix(overlay): detect conflicts between overlay and install | craft-parts | merged | Merged PR #1190 fixed Stage collision detection by including overlay layer contents and added integration tests for colliding and non-colliding scenarios in commit b7455277. |