← Back to issue list

Clean up return of `install_packages`

View original Github issue

Metadata

Project
craft-parts
Number
#1328
Type
issue
State
open
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Maintainer cleanup task: make install_packages return None since its return value is unused. Spawned by a TODO in yum.py. No labels, no comments, no activity in 342 days. The referenced TODO comment is no longer in the code, but install_packages still returns list[str] in yum.py, base.py, and deb.py, so the change is not yet done.

Suggested action: keep open

Reason: This is a valid, well-scoped maintainer cleanup task (bepri) with a concrete premise: callers in executor.py:300 and part_handler.py:382/386 ignore the return value, yet install_packages still returns list[str] in yum.py, base.py, and deb.py. It is not stale-dead because the underlying code still exhibits the described behavior and the fix is small and self-contained; however it has had zero maintainer interaction and no labels for 342 days, so it needs triage/assignment rather than closure. Confidence is moderate because the referenced TODO comment no longer appears in yum.py, so I could not confirm the exact original wording or whether a partial cleanup already landed.

Impact: 20 Quick Win: 13.0 Staleness: 72 Complexity: 35 Confidence: 62 Support Request: 0

Issue body

### What needs to get done The `install_packages` method shouldn't return anything, as the information isn't used. ### Why it needs to get done Spawned by the following TODO comment. https://github.com/canonical/craft-parts/blob/70fc3bac64c17457fd90817fde749cfa8057cd78/craft_parts/packages/yum.py#L144

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 20
Quick Win: 13.0
Staleness: 72
Complexity: 35
Confidence: 62
Support Request: 0
keep open Maintainer cleanup task: make install_packages return None since its return value is unused. Spawned by a TODO in yum.py. No labels, no comments, no activity in 342 days. The referenced TODO comment is no longer in the code, but install_packages still returns list[str] in yum.py, base.py, and deb.py, so the change is not yet done.
qwen/qwen3.6-35b-a3b
Staleness: 80
Complexity: 10
Confidence: 75
Support Request: 0
needs triage Code cleanup task to remove unused return value from install_packages method. Issue remains unlabelled, unassigned, and inactive for over 10 months with no maintainer engagement.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 90
Support Request: 0
needs triage Code cleanup to remove an unused return value from the install_packages method. Open for 288 days with no labels, comments, or assignee.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 10
Confidence: 85
Support Request: 0
needs triage Remove the unused return value from the install_packages method per an existing TODO. The task remains open, unassigned, unlabeled, and inactive for over nine months with no discussion.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.