Clean up return of `install_packages`
Metadata
Current evaluation
Cleanup remains open: install_packages still returns package manifests that internal callers discard; PR #1671 removed the related list_only parameter but not the return contract.
Suggested action: needs triage
Reason: Executor and overlay call sites discard install_packages' result, confirming the unused return. However, BaseRepository still declares list[str], Debian computes installed manifests, and current integration tests assert those versions; PR #1671 removed only list_only, so the API and test implications need maintainer triage.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
38
Quick Win:
12
Complexity:
52
Confidence:
94
Actionability:
64
|
needs triage | Cleanup remains open: install_packages still returns package manifests that internal callers discard; PR #1671 removed the related list_only parameter but not the return contract. | |
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
10
Complexity:
60
Confidence:
70
Actionability:
80
|
keep open | Remove unused return value from install_packages method across the packages interface | |
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
13
Staleness:
72
Complexity:
35
Confidence:
62
Support Request:
0
|
keep open | Maintainer cleanup task: make install_packages return None since its return value is unused. Spawned by a TODO in yum.py. No labels, no comments, no activity in 342 days. The referenced TODO comment is no longer in the code, but install_packages still returns list[str] in yum.py, base.py, and deb.py, so the change is not yet done. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
80
Complexity:
10
Confidence:
75
Support Request:
0
|
needs triage | Code cleanup task to remove unused return value from install_packages method. Issue remains unlabelled, unassigned, and inactive for over 10 months with no maintainer engagement. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
10
Confidence:
90
Support Request:
0
|
needs triage | Code cleanup to remove an unused return value from the install_packages method. Open for 288 days with no labels, comments, or assignee. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#1671
(confidence 98%)
Commit f6b073fe removed list_only, one element of the original TODO, but retained the list return contract.
Related issues
No related issues found above the similarity threshold.