← Back to issue list

Merge similar error types

View original Github issue

Metadata

Project
craft-parts
Number
#1331
Type
issue
State
open
Author
bepri
Labels
Status: Triaged
Created
Updated
Closed

Current evaluation

Cleanup task to merge near-duplicate error types InvalidSourceOption and InvalidSourceOptions in craft_parts/sources/errors.py. Labeled Status: Triaged; both types still exist and are raised in sources/base.py, so the work remains unaddressed.

Suggested action: keep open

Reason: The issue is labelled 'Status: Triaged' (maintainer-acknowledged) and the underlying problem is verifiably still present: both error classes remain in craft_parts/sources/errors.py and are still raised separately in sources/base.py, with no commit having merged them. It is a legitimate, well-scoped cleanup task, not stale-irrelevant, so it should stay open; complexity is moderate because the types are part of the public API and downstream consumers may catch them.

Impact: 15 Quick Win: 9.0 Staleness: 65 Complexity: 40 Confidence: 85 Support Request: 0

Issue body

### What needs to get done `InvalidSourceOption` and `InvalidSourceOptions` should be merged into a singular error type. ### Why it needs to get done Spawned from the following TODO comment: https://github.com/canonical/craft-parts/blob/a20b49d1b27ecd00ab74eb786d0f2403184adc97/craft_parts/sources/errors.py#L67

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 15
Quick Win: 9.0
Staleness: 65
Complexity: 40
Confidence: 85
Support Request: 0
keep open Cleanup task to merge near-duplicate error types InvalidSourceOption and InvalidSourceOptions in craft_parts/sources/errors.py. Labeled Status: Triaged; both types still exist and are raised in sources/base.py, so the work remains unaddressed.
qwen/qwen3.6-35b-a3b
Staleness: 80
Complexity: 15
Confidence: 90
Support Request: 0
keep open Refactor to merge `InvalidSourceOption` and `InvalidSourceOptions` error types per a code TODO. Labeled triaged but inactive for ~10 months with no maintainer follow-up.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 10
Confidence: 85
Support Request: 0
close stale Request to merge InvalidSourceOption and InvalidSourceOptions error types. Triaged by a maintainer but inactive for over 9 months with no implementation or discussion.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 10
Confidence: 70
Support Request: 0
keep open Consolidate InvalidSourceOption and InvalidSourceOptions into a single error type. The task is triaged and linked to an internal Jira ticket, but remains unassigned and inactive for over eight months.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.