← Back to issue list

style: add easy noqa fixes

View original Github issue

Metadata

Project
craft-parts
Number
#1340
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1340 (commit 656270ad), adding easy noqa fixes and removing obsolete TODO/XXX comments across 41 files.

Resolution: closed resolved

Reason: PR #1340 was approved and merged as commit 656270ad, resolving the requested lint cleanup despite one nonessential test job failing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes the easy, low-hanging fruit `noqa`s. These were found by regex-searching for `# noqa: (?!PTH)[A-Z]+\d+`. Any `noqa`s that still appear under that search, I decided were reasonable to keep or should be addressed in a separate PR. All of the `TODO`/`XXX` comments that were removed had a new issue opened for them, except for a few that are explained in comments below

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1340 (commit 656270ad), adding easy noqa fixes and removing obsolete TODO/XXX comments across 41 files.
stealth/space-bunny-alpha — closed resolved PR #1340 by bepri merged into craft-parts main as commit 656270ad, fixing easy non-PTH ruff noqa suppressions across 41 files (+100/-110) and opening new issues for the removed TODO/XXX comments.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-parts#1340, removing easy noqa suppressions across 41 files and opening tracking issues for removed TODO/XXX comments.
qwen/qwen3.6-35b-a3b — — Merged after two reviewer approvals. The changes remove easy noqa comments across 41 files and replace removed TODO/XXX comments with new tracking issues. CI checks passed, and the code was successfully integrated.
qwen3.6-35b-a3b-mtp-q6 — — Merged a style fix that automatically resolved easy noqa comments via regex. Removed associated TODO and XXX comments, opening follow-up issues for most. A few were retained or deferred to separate PRs.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.