fix: add setup command to meson
Metadata
Current evaluation
Merged PR #1346 as commit 6b90766d, changing the Meson plugin to run meson setup before ninja build and install commands.
Resolution: closed resolved
Reason: The approved PR was merged as commit 6b90766d. Repository history confirms that the Meson plugin now invokes meson setup with the source subdirectory.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Since version 0.53 at least (available in Ubuntu 20.04), meson has supported the `setup` command, and since version 1.0.0 at least it explicitly shows a warning message when it is not added to the command line. But the *craft tools don't add it.
This patch adds the `setup` command to the parts.
- [X] Have you followed the guidelines for contributing?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [X] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1346 as commit 6b90766d, changing the Meson plugin to run meson setup before ninja build and install commands. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1346 (commit 6b90766d) adds Meson's setup command to build steps and updates the changelog, avoiding warnings when setup is omitted. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1346 (6b90766d), adding the setup command to Meson build steps and updating the changelog. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix adding the setup command to meson build steps, resolving deprecation warnings in meson 0.53+. Approved by three reviewers, passed CI, and updated the changelog. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that adds the meson setup command to craft tool parts. This resolves deprecation warnings introduced in meson versions 0.53 and 1.0.0. The changelog entry was repositioned during review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #180 plugins: add meson plugin | craft-parts | merged | Merged PR #180 added Meson plugin support and fixed out-of-source-build handling. Changes landed in commit 228706de and were merged as a48ad0b9. |