fix: ignored outdated files should still be pulled
Metadata
Current evaluation
PR #1383 (merge commit 11eddde0) fixed #1373: files excluded from outdated checks (e.g. spread.yaml) are now still copied into the pull, so parts using `git describe --dirty` are no longer permanently reported dirty. Merged with 2 approvals, all CI passing.
Resolution: closed resolved
Reason: Merged into main as commit 11eddde0, credited to CRAFT-4884 and explicitly fixing issue #1373; the outdated-file ignore list no longer suppresses pulling of those files. Maintainer cmatsuoka asked lengau to confirm the fix in comment on 2025-10-31.
Evaluated by: mr-cal-bot
No scores available.
Issue body
During the execution of the lifecycle there are files or directories
that should not be pulled, such as the `parts` or `stage`. There are
also files that should be pulled and ignored by the outdated file
checker, such as `spread.yaml`. If we don't pull files that are in
the repository parts that set `version` using `git describe --dirty`
will always describe the state of the repository as dirty.
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
CRAFT-4884
Fixes #1373
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1383 (merge commit 11eddde0) fixed #1373: files excluded from outdated checks (e.g. spread.yaml) are now still copied into the pull, so parts using `git describe --dirty` are no longer permanently reported dirty. Merged with 2 approvals, all CI passing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/craft-parts#1383 (11eddde0), fixing #1373 by pulling outdated-checker-ignored files so git describe --dirty is not falsely reported as dirty. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for #1373 ensuring ignored files like spread.yaml are still pulled, preventing false dirty state reports from git describe. Approved by two reviewers with all CI checks passing. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for #1373 ensuring ignored outdated files are correctly pulled. Resolves a bug where the outdated file checker skipped necessary files, causing git describe to incorrectly report dirty states. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-parts#1373
(confidence 95%)
PR body states 'Fixes #1373'; that issue is now closed with ignore_outdated support implemented by this PR/commit.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1122 feat: also ignore outdated spread-reuse files | craft-application | merged | Merged PR #1122 (commit 2b1cc802) adds .spread-reuse.* to the ignore list used when deciding if a source is outdated, with lint and most test jobs passing. |