← Back to issue list

build(docs): make `clean` target scrub `reference/gen`

View original Github issue

Metadata

Project
craft-parts
Number
#1423
Type
pull request
State
merged
Author
medubelko
Labels
Created
Updated
Closed

Current evaluation

Merged. Updated the build clean target to explicitly scrub docs/reference/gen instead of relying on implicit Git ignores. Approved by three reviewers and passed CI checks, including all test suites and linting.

Suggested action:

No scores available.

Issue body

The `docs/reference/gen` path was implicitly ignored by Git, but it's now explicit. @lengau This doesn't have to make it into the 2.28.0 release; up to you. --- - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Updated the build clean target to explicitly scrub docs/reference/gen instead of relying on implicit Git ignores. Approved by three reviewers and passed CI checks, including all test suites and linting.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated the clean target to explicitly remove the docs/reference/gen directory, replacing implicit Git ignore behavior. The change was accepted by maintainer medubelko and does not require inclusion in the 2.28.0 release.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#477 build(docs): make `clean` target scrub `docs/reference/gen` starbase merged Merged upstreamed changes to update the build clean target, ensuring it removes the generated docs/reference/gen directory. Approved by two reviewers and passed all CI checks.
94%
#594 build: run docs-clean as part of clean target starbase merged Merged a one-line Makefile update adding docs-clean to the clean target. This resolves CI lint failures from stale documentation styles by ensuring make clean removes generated artifacts. Approved by two reviewers and passed all CI checks.
76%
#566 build(docs): override docs-clean target starbase merged Merged. Overrides the docs-clean Makefile target to prevent accidental virtual environment deletion and resolve ambiguous test command failures during documentation cleanup. Approved by reviewers and passed all CI checks.
75%
#5572 fix(docs): remove obsolete CLI reference pages after generation snapcraft merged Merged a fix that automatically removes obsolete CLI documentation files after regeneration, preventing build errors. Approved by reviewers, passed CI checks, and closed the related issue.
72%
#513 build(docs): fix double build with docs-lint starbase merged Merged a one-line fix resolving a double build issue during docs-lint by correcting a mistaken assumption about Sphinx's linter requirements. Approved by two reviewers, passed CI, and closed issue #512.
70%
#525 build: fix docs-install target starbase merged Merged a build fix optimizing the docs-install target by retaining dev dependencies throughout make lint execution. Approved by reviewers and passed CI checks, yielding a faster and more correct linting process.
70%