← Back to issue list

feat: Comment out replace statements to relative paths in go.mod

View original Github issue

Metadata

Project
craft-parts
Number
#1466
Type
pull request
State
open
Author
atandrewlee
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds go-use plugin logic to strip relative-path replace statements from go.mod, with integration tests. Changes requested; maintainer notes *-use plugins are obsolete post-Madrid, deferring to tigarmo on whether to adapt to the newer Go plugin.

Suggested action: keep open

Reason: Maintainer @steinbro (2026-08-10) states the *-use plugins are 'effectively obsolete post-Madrid' and defers to @tigarmo on whether to adapt the fix into the newer Go plugin, leaving the decision open. The author's last activity (2026-03-27) was a review request, and the PR has 2 unresolved review comments plus failing architecture-specific CI, so it is not ready to land but is not clearly irrelevant either.

Impact: 35 Quick Win: 19.25 Staleness: 55 Complexity: 45 Confidence: 70

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- From the discussion on the PR #1391, this PR adds logic to the `go-use` plugin 1. Checks if a `go.mod` exists or return an error 2. If the go.mod exists, it will remove replace statements that point to relative paths (starts with `./` or `../`) 3. An integration test to ensure this works (with both imports of one-line replace statements & multi line replace() blocks Note: I need to run make lint & test (I wasn't on an Ubuntu machine when developing this). Will do soon

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 35
Quick Win: 19.25
Staleness: 55
Complexity: 45
Confidence: 70
keep open Adds go-use plugin logic to strip relative-path replace statements from go.mod, with integration tests. Changes requested; maintainer notes *-use plugins are obsolete post-Madrid, deferring to tigarmo on whether to adapt to the newer Go plugin.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 35
Confidence: 95
close stale Modifies go-use plugin to strip relative replace statements from go.mod. Review requested, CI has architecture-specific failures, maintainer notes the plugin is obsolete.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 45
Confidence: 60
needs review Modifies go-use plugin to strip relative path replace statements from go.mod. Currently awaiting maintainer review with 7 unresolved comments and pending CI fixes.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 50
Confidence: 80
close stale Adds logic to go-use plugin to comment out relative path replace statements in go.mod. Currently inactive for over 3 months, awaiting maintainer feedback on implementation approach and missing CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 40
Confidence: 75
needs review Updates the go-use plugin to comment out relative path replace statements in go.mod. Awaiting review and feedback on implementation approach and default behavior. Requires lint and test execution.

Update history

Date Change
updated

Related work

  • Caused By: craft-parts#1391 (confidence 85%)

    PR body states this work comes from the discussion on PR #1391, which reported go-use failing on relative replace directives in go.mod.

Related issues

No related issues found above the similarity threshold.