← Back to issue list

fix: handle use_host_sources on OverlayManager.run()

View original Github issue

Metadata

Project
craft-parts
Number
#1524
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1524 (commit dd05222e) makes OverlayManager.run() inject the configured use_host_sources default when override-overlay scripts omit it.

Resolution: closed resolved

Reason: The approved PR was merged as commit dd05222e. Its OverlayManager.run() change applies use_host_sources with setdefault while preserving explicit per-call overrides.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The method is called directly when executing override-overlay scripts, so the default behavior should be to inject the kwarg if not provided. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1524 (commit dd05222e) makes OverlayManager.run() inject the configured use_host_sources default when override-overlay scripts omit it.
stealth/space-bunny-alpha — closed resolved Merged PR #1524 fixes OverlayManager.run() to supply the default use_host_sources value when override-overlay scripts omit the kwarg (commit dd05222e).
qwen/qwen3.6-35b-a3b — — Merged fix to automatically inject the use_host_sources kwarg in OverlayManager.run() during override-overlay script execution. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that automatically injects the use_host_sources keyword argument in OverlayManager.run() when executing override-overlay scripts if not explicitly provided.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1483 (confidence 95%)

    Commit bedb4c0f introduced the host-source overlay behavior that this PR corrected.

Related issues

No related issues found above the similarity threshold.