← Back to issue list

test(cmake_plugin): update version requirement

View original Github issue

Metadata

Project
craft-parts
Number
#1528
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1528 as 89e8a05f, raising the CMake test projects' minimum version so CMake 4 on Resolute accepts them and the plugin tests pass.

Resolution: closed resolved

Reason: PR #1528 was approved and merged as commit 89e8a05f. It updates both CMake test projects to declare a version compatible with CMake 4, with a passing Resolute test run provided.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The cmake plugin tests were previously failing on Resolute as it ships with cmake 4, which is incompatible with cmake < 3.5. This PR updates test_cmake_plugin to use a version of cmake compatible with cmake 4. See [tests passing here](https://github.com/canonical/craft-parts/actions/runs/23895043823/job/69677561661?pr=1527) on Resolute. (CRAFT-5064) - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1528 as 89e8a05f, raising the CMake test projects' minimum version so CMake 4 on Resolute accepts them and the plugin tests pass.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#1528 (89e8a05f), updating the CMake plugin test to use a version compatible with CMake 4 and restore passing tests on Resolute.
qwen/qwen3.6-35b-a3b — — Merged an update to the cmake plugin test version requirement to resolve Resolute CI failures caused by cmake 4 incompatibility. The change adjusts the test to use a compatible cmake version, ensuring successful execution across all platforms.
qwen3.6-35b-a3b-mtp-q6 — — Merged an update to the cmake plugin tests to use a version compatible with cmake 4, resolving test failures on Resolute. The change ensures compatibility and passes CI checks.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1527 (confidence 98%)

    Exploratory Resolute and CMake 4 PR whose passing test run was cited by #1528.

Related issues

Issue Project State Summary Similarity
#1512 Handle cmake 3 vs. cmake 4 craft-parts closed CMake 4 compatibility was addressed by merged PR #1528 (commit 89e8a05f), updating the CMake plugin test requirement and restoring passing tests on Ubuntu Resolute.
73%