fix(executor): handle empty-string organize path
Metadata
Current evaluation
Merged #1532 in commit 46eeb3e8, making organize: {'': ''} a no-op when source and destination resolve to the same directory; #1526 was closed.
Resolution: closed resolved
Reason: PR #1532 was merged as commit 46eeb3e8 after review and passing checks. It added same-directory handling for empty-string organize paths with regression coverage, resolving #1526.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
Handle `organize: {'': ''}` as a no-op when the source and destination resolve to the same directory.
## Testing
- `pytest -q tests/integration/executor/test_organize.py -rs`
- `pytest -q tests/integration/executor/test_environment.py -k expand_environment -rs`
## Issue
Closes #1526
## AI assistance
AI assistance was used while addressing review feedback and validating this follow-up. I reviewed and understand the resulting code and tests and remain responsible for the contribution.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1532 in commit 46eeb3e8, making organize: {'': ''} a no-op when source and destination resolve to the same directory; #1526 was closed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1532 fixed empty-string organize handling in commit 46eeb3e8: organize {'': ''} is now a no-op when source and destination resolve to the same directory; closes #1526. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1532 (commit 46eeb3e8) fixed empty-string organize paths, treating organize: {'': ''} as a no-op when source and destination resolve to the same directory; closes #1526. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for #1526 handling empty-string organize paths as a no-op when source and destination match. Approved by three reviewers, passed all CI checks, and added to the changelog. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
15
Confidence:
90
|
needs review | Fixes executor to treat empty-string organize paths as a no-op when source and destination match. Approved by two reviewers, CI passes except for an unrelated s390x JVM crash. Awaiting maintainer re-run of failing job. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
25
Confidence:
85
|
needs review | Fixes empty-string organize path handling by treating identical source and destination as a no-op. Approved by one reviewer, CI passes except a known s390x JVM crash, awaiting maintainer CI retry. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
40
Complexity:
15
Confidence:
90
|
needs review | Fixes empty-string organize path handling by treating it as a no-op when source and destination match. Approved by one reviewer, CI passing except unrelated s390x JVM crash, awaiting maintainer re-run. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
15
Confidence:
80
|
needs review | Fixes empty-string organize path handling by treating identical source and destination as a no-op. Approved by one reviewer with one unresolved comment. CI passes, awaiting maintainer response to contributor ping. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
15
Confidence:
85
|
needs review | Fixes empty-string organize path handling by treating matching source and destination directories as a no-op. Approved by one reviewer with one unresolved comment. CI passing, awaiting maintainer response to contributor ping. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
20
Confidence:
85
|
needs review | Fixes empty-string organize path handling by treating matching source/destination as a no-op. Approved by one reviewer with one unresolved comment. CI mostly passes with two flaky failures. Author recently pinged maintainers to rebase or refresh checks. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
45
Complexity:
15
Confidence:
85
|
needs review | Fixes executor to treat empty-string organize paths as a no-op when source and destination resolve to the same directory. PR is ready, CI passes, awaiting maintainer review after contributor ping. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
15
Confidence:
85
|
needs review | Fixes executor to treat empty-string organize paths as a no-op when source and destination resolve to the same directory. Currently pending maintainer review with CI mostly passing and a contributor ping requesting next steps. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
60
Complexity:
15
Confidence:
85
|
needs review | Fixes handling of empty-string organize paths by treating same-directory source/dest as a no-op. Closes #1526. Contributor recently pinged maintainers and offered to rebase or refresh checks. Awaiting maintainer review. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated |
Related work
-
Likely Fixed By:
craft-parts#1526
(confidence 100%)
PR #1532 explicitly closes #1526, whose summary records the fix in commit 46eeb3e8.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1526 Strange behaviour when organizing from an empty string | craft-parts | closed | Fixed by merged PR #1532 in commit 46eeb3e8, which handles empty-string organize paths as a no-op when source and destination resolve to the same directory. |