← Back to issue list

fix(sources): handle streaming request errors

View original Github issue

Metadata

Project
craft-parts
Number
#1533
Type
pull request
State
merged
Author
gcomneno
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Wraps streaming file download request exceptions into NetworkRequestError to surface proper source-facing errors. Approved by two reviewers and merged after resolving transient CI failures and adding a changelog entry. Closes #1396.

Suggested action: —

No scores available.

Issue body

## Summary Wrap request exceptions raised while streaming file source downloads into `NetworkRequestError`, so file source failures surface as source-facing errors instead of raw `requests` exceptions. ## Testing - `pytest -q tests/unit/sources/test_base.py -rs` ## Issue Closes #1396

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Wraps streaming file download request exceptions into NetworkRequestError to surface proper source-facing errors. Approved by two reviewers and merged after resolving transient CI failures and adding a changelog entry. Closes #1396.
qwen3.6-35b-a3b-mtp-q6
Staleness: 25
Complexity: 15
Confidence: 85
needs review Wraps streaming file download exceptions into NetworkRequestError to surface proper source-facing errors instead of raw requests exceptions. Closes #1396. Awaiting CI rerun due to unrelated transient failures; ready for maintainer review and merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#743 fix: add proper error messages (#738) craft-parts merged Merged fix adding clearer error messages for invalid source paths and network failures. NetworkRequestError now includes the source URL. Approved by two reviewers and passed CI, resolving issue #738.
73%