← Back to issue list

feat: deprecate OsRelease in favor of distro

View original Github issue

Metadata

Project
craft-parts
Number
#1581
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Deprecates os_utils.OsRelease in favor of the distro PyPI package across 18 files (+179/-132). Approved by 1 reviewer, but 3 unresolved review comments and 19 failing checks; no author activity for 128 days.

Suggested action: needs review

Reason: Review status is 'approved (1 reviewers)' yet 'Unresolved review comments: 3' remain, and 19 checks are failing including 'test-common / Minimum dependencies' and 'Security scan / OSV-scanner'. A concrete correctness risk is visible: 'distro>=1.9.0' sits only in the pyproject.toml dev dependency-group, not [project] dependencies, so a runtime import would break packaging. The branch has had no activity for 128 days while releases continued to 2.37.1, so it needs maintainer attention before landing, not a merge.

Evaluated by: mr-cal-bot

Impact: 45 Quick Win: 6 Complexity: 60 Confidence: 78 Actionability: 35

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 45
Quick Win: 6
Complexity: 60
Confidence: 78
Actionability: 35
needs review Deprecates os_utils.OsRelease in favor of the distro PyPI package across 18 files (+179/-132). Approved by 1 reviewer, but 3 unresolved review comments and 19 failing checks; no author activity for 128 days.
~deepseek/deepseek-pro-latest
Impact: 48
Quick Win: 10
Complexity: 50
Confidence: 65
Actionability: 40
needs review Deprecates OsRelease in favor of the distro library across 18 files (+179/-132). Approved by one reviewer but has 3 unresolved review comments and several failing CI checks; no activity for 128 days.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 7
Complexity: 30
Confidence: 95
Actionability: 20
close superseded PR #1569 deprecates OsRelease in favor of distro across 18 files. Superseded by PR #1581 which carries the same changes and remains open.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 22
Staleness: 75
Complexity: 50
Confidence: 85
close stale Deprecates the OsRelease utility in favor of the distro package across 18 files to avoid a major version bump. Closed and superseded by PR #1581, which carries the same changes and remains open.
qwen/qwen3.6-35b-a3b
Staleness: 45
Complexity: 45
Confidence: 70
needs review Deprecates OsRelease module in favor of distro across 18 files. Has one approval but three unresolved review comments and no author responses. CI shows mixed results with some failing slow tests.
qwen3.6-35b-a3b-mtp-q6
Staleness: 70
Complexity: 20
Confidence: 65
needs review PR deprecates OsRelease in favor of distro. Currently inactive for 43 days with no comments or review, containing only contribution checkboxes.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#1569 (confidence 92%)

    Inverted relationship: #1569 shares the title and was 'closed unmerged and superseded by canonical/craft-parts#1581, which carries the changes to deprecate OsRelease in favor of distro without removing the API.' This PR supersedes #1569, not vice versa; no newer commit supersedes it (OsRelease still live at HEAD aa26742).

Related issues

Issue Project State Summary Similarity
#1569 feat: deprecate OsRelease in favor of distro craft-parts closed Closed unmerged and superseded by canonical/craft-parts#1581, which carries forward the OsRelease deprecation in favor of distro.
72%
#1742 feat!: replace OsRelease with distro craft-parts open Replaces the public OsRelease wrapper with distro across chroot checks, platform detection, Poetry, and tests. Open with lint/files and both minimum-dependency jobs failing; eight checks remain pending.
70%