← Back to issue list

Add Patches Directive

View original Github issue

Metadata

Project
craft-parts
Number
#1588
Type
pull request
State
open
Author
bryanfraschetti
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a patches directive applying a list of patch files to the source tree during the pull stage (closes #1587). Approved by 1 reviewer, but 6 unresolved review comments, failing CI, and an open design discussion over the hardcoded -p1 flag.

Suggested action: keep open

Reason: The PR is in an active review cycle: the author reported TestSequencer failures and asked for opinions (2026-05-20), and maintainer cmatsuoka replied (2026-05-21) that the design must be refined to fix the hardcoded -p1 and suggested override-pull to gather real use cases. With activity 11 days ago and clear, actionable maintainer feedback, the PR is under development rather than stale or unmergeable; it is not ready to land due to unresolved comments and failing CI.

Impact: 45 Quick Win: 18.0 Staleness: 10 Complexity: 60 Confidence: 80

Issue body

Add a directive called patches which takes a list of filenames that should be applied on top of the source tree during the pull stage, similar to how Debian packaging enables patching through local files in debian/patches/ and a series file that defines the patch order. Closes: #1587 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 45
Quick Win: 18.0
Staleness: 10
Complexity: 60
Confidence: 80
keep open Adds a patches directive applying a list of patch files to the source tree during the pull stage (closes #1587). Approved by 1 reviewer, but 6 unresolved review comments, failing CI, and an open design discussion over the hardcoded -p1 flag.
qwen/qwen3.6-35b-a3b
Staleness: 70
Complexity: 55
Confidence: 85
keep open Introduces a 'patches' directive to apply patch files during the pull stage. Currently blocked by design feedback, with 6 unresolved comments, failing CI, and ~3 months of inactivity.
qwen/qwen3.6-35b-a3b
Staleness: 75
Complexity: 55
Confidence: 85
needs review Adds a patches directive for applying source patches during the pull stage. Currently approved by one reviewer but has 6 unresolved comments, failing CI tests, and stalled for two months pending design feedback on hardcoded patch levels.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 55
Confidence: 85
keep open Introduces a patches directive to apply source patches during the pull stage. Currently awaiting author response to maintainer feedback requesting design refinement and alternative implementation approaches before test fixes.
qwen3.6-35b-a3b-mtp-q6
Staleness: 20
Complexity: 50
Confidence: 90
keep open Introduces a patches directive to apply patch files during the pull stage. Currently under review with test failures. Reviewer suggests design refinements for patch level handling and recommends gathering real-world use cases before finalizing.

Update history

Date Change
updated

Related work

  • Related To: craft-parts#1587 (confidence 95%)

    PR body explicitly states 'Closes: #1587', the feature request for a native patches directive; the issue remains open and no other implementation exists in the codebase.

Related issues

Issue Project State Summary Similarity
#1587 Add a Patches Directive to Allow Custom Patching on top of the Source Tree craft-parts open Feature request for a patches directive to apply local patches to the source tree during the pull stage. A maintainer gave design feedback (prefer git-based approach, override-pull), and PR #1588 is open to implement it with unresolved review comments.
84%