Add Patches Directive
Metadata
Current evaluation
Adds a `patches` part property to apply patch files over the source tree during pull. Approved once, but 6 unresolved comments, 13 failing checks (all test-common suites), and maintainer wants the hardcoded -p1 design revisited.
Suggested action: needs review
Reason: Maintainer cmatsuoka explicitly withheld design sign-off: 'although this is good for patch application convenience, the design must be refined a bit to resolve the problem of `-p1` being hardcoded. I would suggest overriding pull for now' — so the single approval is not a merge signal. CI corroborates the author's own report of TestSequencer failures ('patches property changed' RERUN vs SKIP) with all 13 test-common jobs failing, plus a Conventional Commits title policy failure and a missing changelog entry. The change is not merged or superseded in HEAD (no 'patches' occurrences in the tree) and inactivity of 42 days is not itself grounds for closing, so it stays open pending maintainer direction on the directive's design.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
42
Quick Win:
6
Complexity:
47
Confidence:
80
Actionability:
28
|
needs review | Adds a `patches` part property to apply patch files over the source tree during pull. Approved once, but 6 unresolved comments, 13 failing checks (all test-common suites), and maintainer wants the hardcoded -p1 design revisited. | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
6
Complexity:
65
Confidence:
70
Actionability:
30
|
keep open | Adds a patches directive to apply patch files during the pull stage. Approved by 1 reviewer but has 6 unresolved review comments, failing CI, and unresolved design feedback about hardcoded -p1 flag. | |
| qwen/qwen3.8-27b |
Impact:
45
Quick Win:
18
Staleness:
10
Complexity:
60
Confidence:
80
|
keep open | Adds a patches directive applying a list of patch files to the source tree during the pull stage (closes #1587). Approved by 1 reviewer, but 6 unresolved review comments, failing CI, and an open design discussion over the hardcoded -p1 flag. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
70
Complexity:
55
Confidence:
85
|
keep open | Introduces a 'patches' directive to apply patch files during the pull stage. Currently blocked by design feedback, with 6 unresolved comments, failing CI, and ~3 months of inactivity. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
75
Complexity:
55
Confidence:
85
|
needs review | Adds a patches directive for applying source patches during the pull stage. Currently approved by one reviewer but has 6 unresolved comments, failing CI tests, and stalled for two months pending design feedback on hardcoded patch levels. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
45
Complexity:
55
Confidence:
85
|
keep open | Introduces a patches directive to apply source patches during the pull stage. Currently awaiting author response to maintainer feedback requesting design refinement and alternative implementation approaches before test fixes. |
Update history
| Date | Change |
|---|---|
| updated |
Related work
-
Related To:
craft-parts#1587
(confidence 95%)
PR body states 'Closes: #1587'; the open feature request for the patches directive, where the maintainer wants implementation details discussed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1587 Add a Patches Directive to Allow Custom Patching on top of the Source Tree | craft-parts | open | Feature request for a native `patches` part key applying local patches during pull. Maintainer steinbro backs the motivation but proposed a Git-native, override-pull-based design; linked PR #1588 still under review. |