fix(organize): nest overlay directory globs
Metadata
Current evaluation
Superseded by pull request #1602. The overlay directory glob nesting fix was replaced by a subsequent implementation.
Suggested action: —
No scores available.
Issue body
## Summary
Make directory glob organize behavior consistent when targeting the overlay pseudo-partition.
Previously, globbed directories organized to `(overlay)/...` were merged directly into the destination, unlike globbed directories organized to partition roots or regular paths. This now nests the source directory name for overlay destinations too.
Fixes #1590.
## Tests
- `python -m pytest -q tests/unit/features/overlay_partitions/test_executor_organize.py -rs`
- `git diff --check`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Superseded by pull request #1602. The overlay directory glob nesting fix was replaced by a subsequent implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by #1602. The change fixed inconsistent directory glob nesting for overlay pseudo-partitions by ensuring source directory names are properly nested during organization. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1602 fix(organize): make organize to overlay behavior consistent | craft-parts | merged | Merged fix correcting glob-key organize behavior to overlay. Glob keys previously merged contents instead of nesting. Update restores expected nesting for consistency. Approved by three reviewers and passed CI checks. | |
| #1590 inconsistency in organize to overlay | craft-parts | closed | Inconsistent directory organization to overlay partitions was fixed in commit 139cbce6 via PR #1602. The change normalizes overlay handling in organize_files() to ensure consistent nesting for glob keys across all destinations. | |
| #1586 fix(organize): allow merging directories in overlay with metadata differences | craft-parts | merged | Merged. Resolves #1487 by permitting overlay directories with differing permissions or ownership to merge without raising FileOrganizeError. Review feedback was incorporated via automated commits, CI passed, and the change was successfully merged. | |
| #1541 fix(organize): make organizing to the overlay idempotent | craft-parts | merged | Merged to fix overlay organization idempotency and resolve #1488. Copilot automatically resolved merge conflicts in commit 4282caa6, reverting BUILD_PARTITION while preserving OVERLAY_PARTITION logic. All tests pass. |