fix(organize): nest overlay directory globs
Metadata
Current evaluation
Overlay directory-glob fix was superseded by merged PR #1602 (commit 139cbce6), which restored consistent nesting for glob keys while explicit keys merge.
Resolution: closed superseded
Reason: Maintainer @cmatsuoka explicitly marked PR #1596 as superseded by #1602. PR #1602 merged as commit 139cbce6 and fixed #1590 with the equivalent overlay organize behavior.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
Make directory glob organize behavior consistent when targeting the overlay pseudo-partition.
Previously, globbed directories organized to `(overlay)/...` were merged directly into the destination, unlike globbed directories organized to partition roots or regular paths. This now nests the source directory name for overlay destinations too.
Fixes #1590.
## Tests
- `python -m pytest -q tests/unit/features/overlay_partitions/test_executor_organize.py -rs`
- `git diff --check`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Overlay directory-glob fix was superseded by merged PR #1602 (commit 139cbce6), which restored consistent nesting for glob keys while explicit keys merge. | |
| stealth/space-bunny-alpha | — | closed superseded | Overlay directory-glob nesting fix was superseded by merged PR #1602, which made organize behavior consistent for overlay destinations. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by pull request #1602. The overlay directory glob nesting fix was replaced by a subsequent implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by #1602. The change fixed inconsistent directory glob nesting for overlay pseudo-partitions by ensuring source directory names are properly nested during organization. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
craft-parts#1602
(confidence 100%)
The closing maintainer comment identifies #1602 as the replacement; it merged in commit 139cbce6.
-
Related To:
craft-parts#1590
(confidence 100%)
PR #1596 was opened to fix overlay organize inconsistency tracked in #1590, which was resolved by #1602.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1602 fix(organize): make organize to overlay behavior consistent | craft-parts | merged | Merged as 139cbce6, fixing a regression from #1541: glob-key overlay organization now nests files, while explicit keys continue to merge them. | |
| #1590 inconsistency in organize to overlay | craft-parts | closed | Maintainer-filed report of inconsistent overlay organize (MERGE vs NEST) was fixed by PR #1602, merged as commit 139cbce6, making glob keys always nest and explicit keys merge. | |
| #1586 fix(organize): allow merging directories in overlay with metadata differences | craft-parts | merged | Merged as 0797420f, closing #1487. Final review changes tightened overlay directory conflict handling and retained strict errors for metadata mismatches. | |
| #1541 fix(organize): make organizing to the overlay idempotent | craft-parts | merged | Merged as commit a1178308: organizing files into the overlay partition is now idempotent, so repeat organization no longer errors on existing destinations. Fixes #1488 (CRAFT-5043); conflicts resolved in merge commit 4282caa6. | |
| #1488 Organizing to the overlay directory is not idempotent | craft-parts | closed | Fixed by merged PR #1541 (commit a1178308), making organization into the overlay idempotent so rebuilds no longer fail on existing destination directories. |