← Back to issue list

states: add prime state class and state loader

View original Github issue

Metadata

Project
craft-parts
Number
#16
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #16 added PrimeState and persistent step-state loading; commit aa062828 landed via merge 524909c6, replacing unmerged PR #12.

Resolution: closed resolved

Reason: PR #16 was approved and merged, adding PrimeState plus state loading and unmarshalling in commit aa062828, included in merge commit 524909c6. It replaced PR #12.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The PrimeState class holds context information collected when the prime step runs for a part. Also add a state loader helper that reads persistent state based on part and state, unmarshaling data into an appropriate state object. This PR replaces PR #12. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #16 added PrimeState and persistent step-state loading; commit aa062828 landed via merge 524909c6, replacing unmerged PR #12.
stealth/space-bunny-alpha — closed resolved Merged PR #16 added PrimeState and a state loader for persistent per-part state, replacing #12; implementation commit aa062828 landed via merge commit 524909c6.
qwen/qwen3.6-35b-a3b — — Merged implementation of a PrimeState class and state loader helper for reading and unmarshaling persistent part state. Approved by two reviewers, this change replaces PR #12 and adds 344 lines across four files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Introduces a PrimeState class to track prime step context and a state loader helper for reading and unmarshaling persistent part state. This implementation supersedes PR #12.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#12 (confidence 100%)

    The earlier unmerged PR was explicitly replaced by PR #16.

Related issues

Issue Project State Summary Similarity
#12 states: add concrete step states craft-parts closed Closed unmerged and split into #13–#16, which separately added PullState, BuildState, StageState, and PrimeState; all four replacement PRs were merged.
77%
#10 states: add step state base class craft-parts merged Merged PR #10 via commit 35d2dde5, adding a base class for step state that preserves execution context, detects relevant changes, and enables unchanged runs to be skipped.
74%
#14 states: add build state class craft-parts merged Merged PR #14 added BuildState for context collected during part build steps, partially replacing unmerged PR #12 in merge commit 373d3a84.
74%
#13 states: add pull state class craft-parts merged Merged PR #13 via df8666c2, adding PullState to retain pull-step context and track relevant properties and project options; it partially replaced PR #12.
74%
#15 states: add stage state class craft-parts merged Merged PR #15 added StageState for stage-step context; implementation commit b16b4b77 landed via merge commit ab80f306.
73%
#17 states: add state metadata and ephemeral state manager craft-parts merged Merged PR #17 added wrapped step-state metadata for lifecycle sequencing and an ephemeral state manager keyed by part and step; merge commit 63369fb9.
72%
#18 states: add stage manager class craft-parts merged Merged PR #18 introduced the initial StateManager for tracking part and step states; implemented in commit 23c8afdc and merged by ccf5b434.
70%