← Back to issue list

Make the `nil` plugin out-of-source

View original Github issue

Metadata

Project
craft-parts
Number
#1610
Type
pull request
State
closed
Author
imatrisciano
Labels
—
Created
Updated
Closed

Current evaluation

PR #1610 proposed making the `nil` plugin out-of-source (breaking change for #1609), passed CI, but was closed unmerged by the author to continue the discussion in issue #1609.

Resolution: closed stale

Reason: No commits were merged: the author closed the PR themselves on 2026-06-16 with the comment "Closing this following the discussion in #1609", and craft_parts/plugins/nil_plugin.py still documents the current in-source behaviour. Issue #1609 remains open and no `static-assets` plugin or out-of-source change appears in the repo.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- This PR makes the `nil` plugin out-of-source. Resolves #1609. This is a **breaking change**, as people using the `nil` plugin are most likely expecting the source files to already be in the **build** directory when executing the **override-build** instructions. If this is merged, such existing projects will have to add a copy instruction from **source** to **build**, like this one: ```yaml parts: my-file: plugin: nil source: data override-build: | # Copy files from source to build. You can optionally add '--link' to create hard-links instead of copies. cp -rf --archive --no-dereference ${CRAFT_PART_SRC}/* ${CRAFT_PART_BUILD} # Existing instructions here ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #1610 proposed making the `nil` plugin out-of-source (breaking change for #1609), passed CI, but was closed unmerged by the author to continue the discussion in issue #1609.
stealth/space-bunny-alpha — closed stale Author closed the proposed breaking nil-plugin change to defer it; nothing was merged, and #1609 remains open for further discussion.
qwen/qwen3.6-35b-a3b — — The nil plugin out-of-source change was abandoned. The author closed the pull request without merging following discussions in issue #1609, indicating the proposed breaking change was not adopted.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned after discussion in issue #1609. The author closed the pull request without merging the nil plugin out-of-source change due to its breaking nature and lack of consensus on migration paths.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#1609 (confidence 95%)

    Tracking issue for unwanted source copying by nil/dump plugins; PR stated it resolves #1609, and the decision to close came from that discussion, which is still open

  • Blocked By: craft-parts#1609 (confidence 70%)

    Maintainers proposed a new `static-assets` plugin as the preferred path; no implementation exists in the tree, so the nil-plugin change was left pending that discussion

Related issues

Issue Project State Summary Similarity
#27 plugins: add the nil plugin craft-parts merged Merged #27, adding a nil plugin for parts with no source (implementation 6f45c94e; merge commit d107f80d).
73%
#300 plugins: improve nil plugin docstring craft-parts merged Merged PR #300 in commit d7c1b68d, expanding the nil plugin docstring with guidance for source-less parts and parts using override-build.
73%