← Back to issue list

feat(package/apt): validate all stage packages

View original Github issue

Metadata

Project
craft-parts
Number
#1682
Type
pull request
State
open
Author
cmatsuoka
Labels
—
Created
Updated
Closed
—

Current evaluation

APT stage-package validation now aggregates every invalid entry before failing; tests pass and 3 reviewers approve, but lint fails, 2 comments remain unresolved, and merge conflicts need resolution.

Suggested action: keep open

Reason: Although all test and security jobs pass and 3 reviewers approved, lint / files is failing, 2 review comments remain unresolved, and lengau explicitly requested that merge conflicts be resolved. Keep it open until these merge blockers are addressed.

Evaluated by: mr-cal-bot

Impact: 43 Quick Win: 13 Complexity: 36 Confidence: 92 Actionability: 48

Issue body

Collect all invalid stage packages instead of raising an error as soon as the first invalid entry is found. Fixes #196 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 43
Quick Win: 13
Complexity: 36
Confidence: 92
Actionability: 48
keep open APT stage-package validation now aggregates every invalid entry before failing; tests pass and 3 reviewers approve, but lint fails, 2 comments remain unresolved, and merge conflicts need resolution.
stealth/space-bunny-alpha
Impact: 37
Quick Win: 19
Complexity: 27
Confidence: 91
Actionability: 69
needs review Improves apt stage-package validation to report every invalid entry instead of stopping at the first; 3 reviewers approved. Tests and security checks pass, but the files lint check fails and 2 review comments remain unresolved.
qwen3.6-35b-a3b-mtp-q6
Impact: 55
Quick Win: 33
Staleness: 25
Complexity: 40
Confidence: 75
needs review Validates all stage packages instead of failing on the first invalid entry. Has 3 approvals but unresolved merge conflicts and failing lint check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 85
needs review Changes apt package validation to collect all invalid stage packages instead of failing on the first one. Fixes #196. Approved by 1 reviewer, 2 unresolved comments, CI passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 20
Confidence: 85
needs review Changes apt package validation to collect all invalid stage packages instead of failing on the first. Approved by one reviewer with one unresolved comment. All CI checks pass.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Validates all stage packages in apt instead of failing on the first invalid entry. Currently awaiting maintainer review with CI checks running. Fixes #196.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 85
needs review Refactors apt stage package validation to collect all invalid entries instead of failing immediately. Currently awaiting maintainer review, with CI failing on lint checks and several tests pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 20
Confidence: 85
needs review Changes apt stage package validation to collect all invalid entries instead of failing on the first one. Fixes #196. Currently pending maintainer review with one failing lint check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 85
needs review Fixes #196 by collecting all invalid stage packages instead of failing on the first. Currently pending maintainer review with CI failing on lint checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 90
needs review Changes apt package validation to collect all invalid stage packages instead of failing on the first one. Currently awaiting maintainer review and pending CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 90
needs review Changes package/apt validation to collect all invalid stage packages instead of failing on the first. Currently awaiting maintainer review with CI checks still running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 30
Confidence: 90
needs review Modifies package/apt validation to collect all invalid stage packages rather than failing immediately. Currently awaiting maintainer review and pending CI test completion.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Changes apt package validation to collect all invalid stage packages instead of failing on the first. Currently pending maintainer review with one unresolved comment and a failing lint check.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 15
Confidence: 90
needs review Changes apt package validation to collect all invalid stage packages instead of failing on the first. Currently pending CI tests and maintainer review. Fixes #196.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Likely Fixed By: craft-parts#196 (confidence 100%)

    The PR body explicitly states that the aggregated stage-package validation fixes issue #196.

Related issues

No related issues found above the similarity threshold.