fix: rebuild part on build-environment changes
Metadata
Current evaluation
PR #1686 (commit 2121e8ed) merged, adding build-environment to the build state's properties of interest so declared env changes trigger a part rebuild; fixes #1218 and is noted in the changelog.
Resolution: closed resolved
Reason: Merged PR #1686 (commit 2121e8ed) by maintainer cmatsuoka, approved by 2 reviewers. It adds 'build-environment' to the relevant properties list in craft_parts/state_manager/build_state.py, closing issue #1218 where build was skipped as 'already ran' despite CARGO_PACKAGES changes; changelog and integration test included.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add build-environment to the build state properties of interest, so
that any changes to declared values will trigger a part rebuild.
Fixes #1218
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1686 (commit 2121e8ed) merged, adding build-environment to the build state's properties of interest so declared env changes trigger a part rebuild; fixes #1218 and is noted in the changelog. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-parts#1686 (commit 2121e8ed), adding build-environment to tracked build-state properties so declared environment changes trigger part rebuilds; fixes #1218. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for #1218 adding build-environment to build state properties. Environment changes now trigger part rebuilds. Approved by two reviewers and integrated following successful CI checks. | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
38
Staleness:
5
Complexity:
30
Confidence:
85
|
needs review | Adds build-environment to dirty-check properties to trigger part rebuilds when changed. Approved by 2 reviewers, all CI passing, 1 unresolved review comment. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
40
Staleness:
10
Complexity:
20
Confidence:
85
|
needs review | Fixes #1218 by adding build-environment to dirty-check state properties, triggering part rebuilds on environment changes. Has 2 approvals, 1 unresolved comment, and failing CI checks. | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
41
Staleness:
10
Complexity:
25
Confidence:
80
|
needs review | Adds build-environment to dirty-check properties so changes trigger part rebuilds. Approved by 2 reviewers with 1 unresolved comment and one failing lint check. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
65
Quick Win:
42
Staleness:
10
Complexity:
35
Confidence:
80
|
needs review | Fixes build-environment changes not triggering part rebuilds (craft-parts#1218). Approved by 2 reviewers with 1 unresolved comment; CI checks pending. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
41
Staleness:
15
Complexity:
25
Confidence:
80
|
needs review | Adds build-environment to dirty-check state properties so changes trigger part rebuilds. Fixes craft-parts#1218. Approved by 2 reviewers, all CI passing, 1 unresolved review comment. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Adds build-environment to build state properties to trigger part rebuilds on changes. Fixes #1218. Currently has two approvals, one unresolved comment, and all CI checks passing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
20
Confidence:
85
|
needs review | Adds build-environment to build state properties to trigger part rebuilds when changed. Fixes #1218. Currently approved by one reviewer with one unresolved comment, all CI checks passing, and awaiting final maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
25
Confidence:
90
|
needs review | Adds build-environment to build state properties to trigger part rebuilds on changes, addressing issue #1218. Currently pending maintainer review with passing CI checks and no comments. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
0
Complexity:
15
Confidence:
90
|
needs review | Adds build-environment to build state properties to trigger part rebuilds when values change. Fixes #1218. Currently pending maintainer review with CI passing and no comments. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
25
Confidence:
85
|
needs review | Adds build-environment to build state properties to trigger part rebuilds when changed. Fixes #1218. Currently pending maintainer review with one unresolved comment and several CI checks still running. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
craft-parts#1218
(confidence 97%)
Issue explicitly fixed by #1686 ('Skipping build for serde (already ran)' despite build-environment change); now closed.
Related issues
No related issues found above the similarity threshold.