fix(plugins/qmake): use source-subdir if declared
Metadata
Current evaluation
Merged PR #1687 (commit 0162da71), fixing qmake path resolution to honor source-subdir while preserving source-root-relative project files.
Resolution: closed resolved
Reason: The qmake plugin now resolves default and explicit project files correctly when source-subdir is declared. Issue #950 was closed by the merged change in commit 0162da71.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fix the qmake plugin to properly recognize `source-subdir` when declare
in the part. If ``source-subdir`` is set and ``qmake-project-file`` already starts
with that prefix, the path is resolved relative to the source directory;
otherwise it is resolved relative to the source subdirectory. This was added
to prevent breaking projects that used ``qmake-project-file`` and also set
``source-subdir``.
Fixes #950
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1687 (commit 0162da71), fixing qmake path resolution to honor source-subdir while preserving source-root-relative project files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1687 (commit 0162da71) to make qmake honor source-subdir when resolving project paths while preserving already-prefixed paths. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1687 (commit 0162da71), fixing qmake to honor declared source-subdir and resolve project-file paths compatibly, closing #950. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged qmake plugin fix to correctly resolve qmake-project-file paths when source-subdir is declared. Adjusts path resolution relative to source or subdirectory to prevent breaking configs. Approved by three reviewers and closes #950. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
50
Quick Win:
32
Staleness:
5
Complexity:
35
Confidence:
85
|
needs review | Fixes qmake plugin to properly handle source-subdir parameter, resolving issue #950. Approved by 3 reviewers with passing CI. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
36
Staleness:
5
Complexity:
35
Confidence:
75
|
needs review | Fixes qmake plugin to properly handle source-subdir parameter. Has 3 approvals, 4 unresolved review comments, and 1 failing CI check. Recently updated. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
30
Staleness:
25
Complexity:
45
Confidence:
75
|
needs review | Fix qmake plugin to properly handle source-subdir parameter. Has 3 approvals, 4 unresolved review comments, and 1 failing CI check. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
25
Confidence:
90
|
needs review | Fixes qmake plugin path resolution for source-subdir and qmake-project-file to prevent breaking existing projects. Approved by 2 reviewers, all CI checks passing, 1 unresolved comment. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
20
Confidence:
85
|
needs review | Fixes qmake plugin to correctly resolve qmake-project-file paths relative to source-subdir when declared. Approved by one reviewer, all CI checks passing, but has one unresolved review comment. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
20
Confidence:
85
|
needs review | Fixes qmake plugin to correctly resolve qmake-project-file paths relative to source-subdir when declared. Currently pending maintainer review with passing CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
20
Confidence:
90
|
needs review | Fixes qmake plugin to correctly resolve qmake-project-file paths when source-subdir is declared. Currently awaiting maintainer review with passing CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
20
Confidence:
85
|
needs review | Fixes qmake plugin to correctly resolve qmake-project-file paths relative to source-subdir when declared. Currently awaiting maintainer review with CI passing and slow tests pending. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
35
Confidence:
85
|
needs review | Fixes qmake plugin to correctly resolve qmake-project-file paths when source-subdir is declared. Currently pending maintainer review with fast CI passing and slow tests running. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
85
|
needs review | Fixes qmake plugin to correctly resolve qmake-project-file paths relative to source-subdir when declared. Currently awaiting maintainer review and pending CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
35
Confidence:
85
|
needs review | Fixes qmake plugin path resolution when source-subdir is declared. Currently awaiting maintainer review with most CI checks passing, though a file lint check is failing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
25
Confidence:
90
|
needs review | Fixes qmake plugin to recognize source-subdir in part declarations. Addresses issue #950. Currently pending maintainer review with CI checks passing or running. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Fixes qmake plugin to properly recognize source-subdir when declared in the part. Currently pending maintainer review with CI passing and one unresolved comment. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Fixes qmake plugin to properly recognize source-subdir when declared in a part. Currently pending maintainer review with multiple test suites running. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Likely Fixed By:
canonical/craft-parts#950
(confidence 100%)
The issue reported qmake ignoring source-subdir and identifies merged PR #1687 as its fix.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #950 qmake plugin ignores source-subdir parameter? | craft-parts | closed | Fixed by merged PR canonical/craft-parts#1687 (commit 0162da71): qmake now honors source-subdir for default and explicit project-file paths. | |
| #633 qmake plugin: Stop doing out-of-source builds. | snapcraft | merged | PR #633 merged as a3f85dcc6, switching qmake from unreliable out-of-source builds to in-source builds and resolving LP #1599572. |