← Back to issue list

Add Python v2 package quoting regression test

View original Github issue

Metadata

Project
craft-parts
Number
#1704
Type
pull request
State
open
Author
copilot-swe-agent
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a unit test for Python plugin v2 package quoting regression. No reviewer engagement yet; related issue #1702 is closed.

Suggested action: needs review

Reason: The PR adds a regression test for Python plugin v2 package quoting (related to closed issue #1702). It has no reviewer engagement yet and the related issue is already closed, creating ambiguity about whether this test is needed or if the fix was already applied elsewhere. A maintainer should review to determine if this test provides valuable regression coverage or if it's redundant with existing tests like `test_get_build_commands_quotes_package_arguments`.

Impact: 30 Quick Win: 27.0 Staleness: 20 Complexity: 10 Confidence: 60

Issue body

Python plugin v2 currently shell-quotes `python-packages` into a scalar variable, causing version specifiers that require quoting to reach pip with literal quote characters. - **Regression coverage** - Adds a focused unit test for Python plugin v2 package handling. - Exercises the generated shell commands with a package specifier containing `>`. - Verifies pip receives the requirement as a single unquoted argument. ```python "python-packages": ["gunicorn>=20.0"] ``` Expected pip argv: ```text install gunicorn>=20.0 ``` <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes #1702

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 30
Quick Win: 27.0
Staleness: 20
Complexity: 10
Confidence: 60
needs review Adds a unit test for Python plugin v2 package quoting regression. No reviewer engagement yet; related issue #1702 is closed.

Update history

Date Change
updated
created

Related work

  • Related To: craft-parts#1702 (confidence 85%)

    Issue #1702 is closed and describes the same quoting bug this PR tests for, but the PR claims to fix it while the issue is already resolved.

Related issues

No related issues found above the similarity threshold.