← Back to issue list

feat: fpc plugin

View original Github issue

Metadata

Project
craft-parts
Number
#1712
Type
pull request
State
open
Author
lczyk
Labels
Created
Updated
Closed

Current evaluation

Adds a Free Pascal (fpc) plugin to craft-parts. Part of a 2-PR set with #1713. Pending maintainer review with 0 reviewers, 1 unresolved comment, and mostly passing CI.

Suggested action: needs review

Reason: This is a brand-new PR (1 day old) adding an fpc plugin with 734 lines across 15 files. It has 0 reviewers and 1 unresolved review comment, so it needs maintainer attention. The author notes the one failing CI test (minimum dependencies) is unrelated and also appears on other PRs.

Impact: 50 Quick Win: 27.5 Staleness: 5 Complexity: 45 Confidence: 70

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- This PR adds a Free Pascal (`fpc`) plugin. Each entry in `fpc-programs` becomes one executable in `$CRAFT_PART_INSTALL/bin`. Units and include files are resolved from `fpc-unit-paths` and `fpc-include-paths`. `fpc-parameters` passes additional compiler options and is placed after the generated flags so it can override them. The plugin does not provision the compiler, to leave the choice of version open. It is expected from `build-packages`, or from a part named `fpc-deps`, following the convention of the other compiler plugins. Search paths go through `shlex.quote`, so a trailing `/*` reaches the compiler unexpanded and fpc resolves it as "every subdirectory of this one". Part of a set: - https://github.com/canonical/craft-parts/pull/1712 **(this PR)** - ~~https://github.com/canonical/craft-parts/pull/1713~~

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 27.5
Staleness: 5
Complexity: 45
Confidence: 70
needs review Adds a Free Pascal (fpc) plugin to craft-parts. Part of a 2-PR set with #1713. Pending maintainer review with 0 reviewers, 1 unresolved comment, and mostly passing CI.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 27.5
Staleness: 5
Complexity: 45
Confidence: 80
needs review Adds a Free Pascal (fpc) plugin to craft-parts. Part of a 2-PR set with #1713. Pending maintainer review with 0 reviewers, 1 unresolved comment, and mostly passing CI.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30.25
Staleness: 5
Complexity: 45
Confidence: 75
needs review Adds a Free Pascal (fpc) plugin to craft-parts. New feature, 0 days old, no reviewers assigned, one CI check failing (author says unrelated). Part of a 2-PR set with #1713.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 20.25
Staleness: 0
Complexity: 55
Confidence: 80
needs review Adds a Free Pascal (fpc) plugin to craft-parts, creating executables from fpc-programs entries with configurable unit/include paths and compiler parameters. Part of a 2-PR set with #1713.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 20.25
Staleness: 5
Complexity: 55
Confidence: 85
needs review Adds the fpc plugin for building Free Pascal programs. New PR with 734 lines across 15 files, no reviewers, no CI results yet.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 27.5
Staleness: 0
Complexity: 45
Confidence: 85
needs review Adds the fpc plugin for building Free Pascal programs, including CI updates and test schema adjustments. Currently pending maintainer review with one unresolved comment.

Update history

Date Change
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: craft-parts#1713 (confidence 95%)

    Part of a 2-PR set; #1713 adds the fpc-use plugin for Free Pascal libraries alongside this fpc plugin.

Related issues

No related issues found above the similarity threshold.