feat: fpc plugin
Metadata
Current evaluation
Adds a Free Pascal compiler plugin with registration, docs, changelog and tests. All test matrices pass, but lint / files fails and no maintainer review has started.
Suggested action: needs review
Reason: The 747-line addition includes tests and documentation, and all fast, slow, architecture-specific, security and policy checks pass. The remaining lint / files failure prevents immediate merge, while the author's claim that it also affects other PRs and the maintainer's request to be pinged once implementation and documentation are complete support sending this for review.
Evaluated by: mr-cal-bot
Impact:
47
Quick Win:
14
Complexity:
56
Confidence:
84
Actionability:
66
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
This PR adds a Free Pascal (`fpc`) plugin. Each entry in `fpc-programs` becomes one executable in `$CRAFT_PART_INSTALL/bin`. Units and include files are resolved from `fpc-unit-paths` and `fpc-include-paths`. `fpc-parameters` passes additional compiler options and is placed after the generated flags so it can override them.
The plugin does not provision the compiler, to leave the choice of version open. It is expected from `build-packages`, or from a part named `fpc-deps`, following the convention of the other compiler plugins.
Search paths go through `shlex.quote`, so a trailing `/*` reaches the compiler unexpanded and fpc resolves it as "every subdirectory of this one".
Part of a set:
- https://github.com/canonical/craft-parts/pull/1712 **(this PR)**
- ~~https://github.com/canonical/craft-parts/pull/1713~~
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
47
Quick Win:
14
Complexity:
56
Confidence:
84
Actionability:
66
|
needs review | Adds a Free Pascal compiler plugin with registration, docs, changelog and tests. All test matrices pass, but lint / files fails and no maintainer review has started. | |
| stealth/space-bunny-alpha |
Impact:
40
Quick Win:
17
Complexity:
38
Confidence:
72
Actionability:
70
|
needs review | New Free Pascal (fpc) compiler plugin: each program builds into bin/, configurable unit/include paths and compiler parameters, plus docs, changelog and tests. All CI green except 'lint / files'; awaiting maintainer review. | |
| stealth/space-bunny-alpha |
Impact:
52
Quick Win:
21
Complexity:
48
Confidence:
82
Actionability:
78
|
needs review | Adds a Free Pascal (fpc) compiler plugin with executable builds, configurable search paths and parameters, docs, and tests; open with no reviewers, no unresolved comments, and only Canonical CLA reported passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
28
Staleness:
5
Complexity:
45
Confidence:
70
|
needs review | Adds a Free Pascal (fpc) plugin to craft-parts. Part of a 2-PR set with #1713. Pending maintainer review with 0 reviewers, 1 unresolved comment, and mostly passing CI. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
28
Staleness:
5
Complexity:
45
Confidence:
80
|
needs review | Adds a Free Pascal (fpc) plugin to craft-parts. Part of a 2-PR set with #1713. Pending maintainer review with 0 reviewers, 1 unresolved comment, and mostly passing CI. | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
30
Staleness:
5
Complexity:
45
Confidence:
75
|
needs review | Adds a Free Pascal (fpc) plugin to craft-parts. New feature, 0 days old, no reviewers assigned, one CI check failing (author says unrelated). Part of a 2-PR set with #1713. | |
| qwen/qwen3.6-35b-a3b |
Impact:
45
Quick Win:
20
Staleness:
0
Complexity:
55
Confidence:
80
|
needs review | Adds a Free Pascal (fpc) plugin to craft-parts, creating executables from fpc-programs entries with configurable unit/include paths and compiler parameters. Part of a 2-PR set with #1713. | |
| qwen/qwen3.6-35b-a3b |
Impact:
45
Quick Win:
20
Staleness:
5
Complexity:
55
Confidence:
85
|
needs review | Adds the fpc plugin for building Free Pascal programs. New PR with 734 lines across 15 files, no reviewers, no CI results yet. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
28
Staleness:
0
Complexity:
45
Confidence:
85
|
needs review | Adds the fpc plugin for building Free Pascal programs, including CI updates and test schema adjustments. Currently pending maintainer review with one unresolved comment. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
craft-parts#1713
(confidence 95%)
Explicitly identified as the companion fpc-use PR; it was closed unmerged after the author pursued this different approach.
Related issues
No related issues found above the similarity threshold.