Metadata

Project

craft-parts

Number

#1729

Type

issue

State

open

Author

bepri

Labels

—

Created

2026-09-21 06:37 PM UTC

Updated

2026-09-28 02:52 PM UTC

Closed

—

Current evaluation

Maintainer-authored style task: 38 exception/warning classes in craft_parts/errors.py and craft_parts/packages/errors.py carry `# noqa: N818`; maintainers agreed to add correctly named errors and deprecate old names at the next major release.

Suggested action: keep open

Reason: The issue is valid and still unaddressed: `grep 'noqa: N818'` returns 38 hits across craft_parts/errors.py and craft_parts/packages/errors.py (e.g. PartDependencyCycle, InvalidPartName, PackagesNotFound), and no recent commit renames them — the errors.py/packages/errors.py history only shows feature and refactor commits. Both the reporter (bepri) and mr-cal are maintainers, and mr-cal's comment defines a concrete migration strategy ('creating correctly named errors and subclassing the old errors ... Later, a major release would remove the old errors'), so the issue is triaged and planned rather than unresolved or stale. Impact is limited to API tidiness/consistency, but renaming risks breaking downstream consumers (craft-apps, craftctl) that catch these exceptions, which justifies the compat-subclass plan.

Evaluated by: mr-cal-bot