test: require root for whiteout tests on Ubuntu 20.04
Metadata
Current evaluation
Merged PR #1748 as commit 21870800, requiring root for Focal whiteout tests, skipping unsupported Focal cases, and updating minimum-dependency CI.
Resolution: closed resolved
Reason: PR #1748 was approved and merged into the main branch as commit 21870800, resolving the Ubuntu 20.04 minimum-dependencies test failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? (test/CI-only change)
## What changed
- On Ubuntu 20.04 only, mark the overlay whiteout tests with `requires_root` (unprivileged users can't `mknod()` 0:0 whiteout devices on focal's 5.4 kernel, and its fuse-overlayfs can't create whiteouts either): `TestOverlayMigrationFilesystems` and the `layer-hides-*` collision scenarios.
- Skip tests that can't run on focal: `test_build_slices` and `test_plugin_overlay` (the chisel-releases `ubuntu-20.04` branch has no `golang-go` or `apt` slices) and `TestOverrideOverlayScriptWithMmdebstrap` (focal's mmdebstrap 0.4.1 doesn't support `--format=dir`).
- Enable the minimum dependencies job for `test-requires-root` on `["amd64", "focal"]`, with `NO_PYTHON=1` (focal has no `python3-poetry` packages) and a `test-command-prefix` that preserves `UV_RESOLUTION` through `sudo`.
- Add `distro` as a dev dependency for the OS checks; drop a now-unneeded `ty` ignore.
## Why is it needed
Fixes the `test-common / Minimum dependencies (all tests)` failure on focal: https://github.com/canonical/craft-parts/actions/runs/36586078459/job/109466646632
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1748 as commit 21870800, requiring root for Focal whiteout tests, skipping unsupported Focal cases, and updating minimum-dependency CI. | |
| qwen/qwen3.8-27b | — | closed resolved | Merged. Test/CI-only change that marks overlay whiteout and collision tests requires_root on Ubuntu 20.04, skips focal-incompatible tests, and enables the test-requires-root minimum-dependencies job on focal to fix the failing CI run. | |
| qwen/qwen3.8-27b |
Impact:
25
Quick Win:
17
Complexity:
20
Confidence:
85
Actionability:
85
|
needs review | Test/CI-only change for craft-parts: marks overlay whiteout tests requires_root on Ubuntu 20.04, skips focal-incompatible tests, and enables the test-requires-root minimum-deps job on focal. Approved, CI green except an unrelated java-plugins s390x job. | |
| qwen/qwen3.8-27b |
Impact:
25
Quick Win:
16
Complexity:
20
Confidence:
85
Actionability:
82
|
needs review | Test/CI-only fix for focal (Ubuntu 20.04): marks overlay whiteout tests requires_root, skips focal-incompatible tests, and enables the test-requires-root minimum-deps job on focal. Approved, CI green except one unrelated noble/s390x java-plugins failure. | |
| stealth/space-bunny-alpha |
Impact:
40
Quick Win:
25
Complexity:
36
Confidence:
95
Actionability:
97
|
needs review | Adds Ubuntu 20.04-specific test requirements and skips, enables focal root-test CI, and adds distro; approved with all checks passing. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1761 test: require root for whiteout tests on Ubuntu 20.04 (backport of #1748) | craft-parts | closed | Backported #1748 to the 2.35 hotfix branch, fixing failing overlayfs whiteout tests on Ubuntu 20.04 by marking them requires_root. |