← Back to issue list

test: check special directories in build-slices test

View original Github issue

Metadata

Project
craft-parts
Number
#1770
Type
pull request
State
open
Author
tigarmo
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds integration test checks for /dev, /proc, and /sys mount points in build-slices. Approved by 2 reviewers with 1 unresolved comment; CI has unrelated failures.

Suggested action: needs review

Reason: The PR has 2 approvals but 1 unresolved review comment that needs attention before merge. The author has responded to CI failures stating they are unrelated. The change is small (+35/-4, 2 files) and adds test coverage for special directory mounts in build-slices.

Evaluated by: mr-cal-bot

Impact: 25 Quick Win: 13 Complexity: 15 Confidence: 75 Actionability: 60

Issue body

Check that /dev, /proc and /sys are being correctly mounted from the host in the integration test. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-parts/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 25
Quick Win: 13
Complexity: 15
Confidence: 75
Actionability: 60
needs review Adds integration test checks for /dev, /proc, and /sys mount points in build-slices. Approved by 2 reviewers with 1 unresolved comment; CI has unrelated failures.

Update history

Date Change
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1763 Ensure proper /proc, /sys and /dev contents in build-slices chroot craft-parts open Build-slices chroot lacks /proc, /sys, and /dev because mountpoints are absent; needs manual directory creation and test verification. Code already creates the dirs via _prepare_build_slices_root, but tests do not yet verify contents.
75%