← Back to issue list

infos: use raw write to set project vars from actions

View original Github issue

Metadata

Project
craft-parts
Number
#187
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #187 (commit b6a7da04, merge 0203f23a), letting skipped actions update project variables via raw writes without enforcing the write-once flag.

Resolution: closed resolved

Reason: The approved change was merged via canonical/craft-parts#187 as commit b6a7da04, resolving CRAFT-942 by supporting multiple skipped steps after project variables are first set.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Don't check the write-once flag when updating project vars from skipped actions because we may have multiple skipped steps after the variable is set. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-942

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #187 (commit b6a7da04, merge 0203f23a), letting skipped actions update project variables via raw writes without enforcing the write-once flag.
stealth/space-bunny-alpha — closed resolved Merged in craft-parts#187 (commit b6a7da04; merge 0203f23a), using raw writes to update project variables from actions and allow multiple skipped steps after initial assignment.
qwen/qwen3.6-35b-a3b — — Merged a fix bypassing the write-once flag when updating project variables from skipped actions, allowing multiple skipped steps to modify variables correctly. Approved by one reviewer, passed CI, and changed 72 lines across four files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to bypass the write-once flag when updating project variables from skipped actions. This prevents errors when multiple skipped steps follow a variable assignment. Resolves CRAFT-942.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#213 infos: fix project var raw write craft-parts merged Merged PR #213 as commit 818c52eb, allowing raw project-variable writes regardless of whether the current part adopts the variable.
82%