← Back to issue list

craftctl: set variables from parts adopting metadata

View original Github issue

Metadata

Project
craft-parts
Number
#190
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged. Restricts craftctl variable assignment to the specified part during lifecycle creation, removing the need for an adopting part when project variables are undeclared. Approved, passed CI, and integrated. Author notes future refactoring for validation and scope adjustments.

Suggested action:

No scores available.

Issue body

Restrict variable setting to the part specified when creating the parts lifecycle. Applications that don't declare project variables don't need to specify an adopting part. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-963

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Restricts craftctl variable assignment to the specified part during lifecycle creation, removing the need for an adopting part when project variables are undeclared. Approved, passed CI, and integrated. Author notes future refactoring for validation and scope adjustments.
qwen3.6-35b-a3b-mtp-q6 Merged. Restricts craftctl variable setting to the specified part during parts lifecycle creation, removing the adopting part requirement when project variables are undeclared. Author notes potential future refactoring for validation and scope adjustments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#217 feat: implement adoptable project variables craft-application merged Merged implementation of adoptable project variables, enabling metadata fields to be set via craftctl. Approved by two reviewers, passed CI, and includes integration tests. Changes span 17 files with 216 additions and 24 deletions.
76%
#3677 parts: add craftctl support snapcraft merged Merged following approval and passing CI. Implements a craftctl wrapper for craft-parts, defines project variables, and adds adopt-info to project configuration. Diff coverage is 84%.
75%
#5753 feat: adopt component variables snapcraft merged Merged after reviewer approval and passing CI checks. The change adopts component variables, enabling craftctl to set component versions for core22 and core24 snaps. Resolves #5240.
70%