← Back to issue list

state_manager: cache dirty reports to reduce recursion

View original Github issue

Metadata

Project
craft-parts
Number
#192
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-parts#192 as commit 88f1090b, caching dirty reports to reduce recursive checks for large dependency chains.

Resolution: closed resolved

Reason: PR #192 was merged through merge commit bac1b029. Commit 88f1090b added a dirty-report cache to improve verification performance for projects such as gnome-sdk.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Verification of dirty parts can take more time than expected when a project has a large number of dependency-chained parts (this happens with gnome-sdk). Cache reports to cut recursion earlier. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-974

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#192 as commit 88f1090b, caching dirty reports to reduce recursive checks for large dependency chains.
stealth/space-bunny-alpha — closed resolved PR #192 merged as commit 88f1090b, adding a dirty-report cache to StateManager to reduce recursion when verifying dependency-chained parts.
stealth/space-bunny-alpha — closed resolved Merged PR #192 as commit 88f1090b, adding dirty-report caching to reduce recursion when verifying large dependency chains.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#192 (bac1b029); state_manager now caches dirty-part reports to reduce recursion and speed verification of large dependency chains.
qwen/qwen3.6-35b-a3b — — Merged updates to cache dirty reports in the state manager, reducing recursion depth and improving performance for large dependency chains. The implementation was simplified to a plain dictionary and approved by a reviewer.
qwen3.6-35b-a3b-mtp-q6 — — Merged a state_manager optimization caching dirty reports to reduce recursion overhead for deep dependency chains. Simplified to a plain dictionary instead of a wrapper class, resolving CRAFT-974.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#83 sequencer: improve dirty state report message (CRAFT-302) craft-parts merged Merged in craft-parts#83 via 16b77c4b, clarifying dirty-state reports to include the changed dependency step name.
74%